[jira] [Commented] (KAFKA-2043) CompressionType is passed in each RecordAccumulator append

["Grant Henke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378046#comment-14378046 ] 

Grant Henke commented on KAFKA-2043:
------------------------------------

Created reviewboard https://reviews.apache.org/r/32440/diff/
 against branch origin/trunk

> CompressionType is passed in each RecordAccumulator append
> ----------------------------------------------------------
>
>                 Key: KAFKA-2043
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2043
>             Project: Kafka
>          Issue Type: Bug
>          Components: clients
>    Affects Versions: 0.8.2.0
>            Reporter: Grant Henke
>            Assignee: Grant Henke
>            Priority: Minor
>         Attachments: KAFKA-2043.patch
>
>
> Currently org.apache.kafka.clients.producer.internals.RecordAccumulator append method accepts the compressionType on a per record basis. It looks like the code would only work on a per batch basis because the CompressionType is only used when creating a new RecordBatch. My understanding is this should only support setting per batch at most. 
>     public RecordAppendResult append(TopicPartition tp, byte[] key, byte[] value, CompressionType compression, Callback callback) throws InterruptedException;
> The compression type is a producer
> level config. Instead of passing it in for each append, we probably should
> just pass it in once during the creation RecordAccumulator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)