You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2024/04/16 07:44:45 UTC
[PR] [INLONG-9995][Manager] Support batch saving of group information and other operations [inlong]
fuweng11 opened a new pull request, #9996:
URL: https://github.com/apache/inlong/pull/9996
### Prepare a Pull Request
- Fixes #9995
### Motivation
Support batch saving of group information and other operations.
### Modifications
Support batch saving of group information and other operations。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9995][Manager] Support batch saving of group information and other operations [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on code in PR #9996:
URL: https://github.com/apache/inlong/pull/9996#discussion_r1568173049
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkServiceImpl.java:
##########
@@ -234,6 +236,29 @@ public Integer save(SinkRequest request, UserInfo opInfo) {
return id;
}
+ @Override
+ public List<BatchResult> batchSave(List<SinkRequest> requestList, String operator) {
+ List<BatchResult> resultList = new ArrayList<>();
+ for (SinkRequest request : requestList) {
+ BatchResult result = BatchResult.builder()
+ .uniqueKey(request.getSinkName() + "-" + request.getInlongGroupId() + "-"
+ + request.getInlongStreamId())
Review Comment:
```suggestion
.uniqueKey(request.getInlongGroupId() + "-"
+ request.getInlongStreamId() + "-" + request.getSinkName() )
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9995][Manager] Support batch saving of group information and other operations [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #9996:
URL: https://github.com/apache/inlong/pull/9996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9995][Manager] Support batch saving of group information and other operations [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on code in PR #9996:
URL: https://github.com/apache/inlong/pull/9996#discussion_r1568173303
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/StreamSourceServiceImpl.java:
##########
@@ -162,6 +164,29 @@ public Integer save(SourceRequest request, UserInfo opInfo) {
return sourceOperator.saveOpt(request, groupEntity.getStatus(), opInfo.getName());
}
+ @Override
+ public List<BatchResult> batchSave(List<SourceRequest> requestList, String operator) {
+ List<BatchResult> resultList = new ArrayList<>();
+ for (SourceRequest request : requestList) {
+ BatchResult result = BatchResult.builder()
+ .uniqueKey(request.getSourceName() + "-" + request.getInlongGroupId() + "-"
+ + request.getInlongStreamId())
Review Comment:
```suggestion
.uniqueKey(request.getInlongGroupId() + "-"
+ request.getInlongStreamId() + "-" + request.getSourceName())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9995][Manager] Support batch saving of group information and other operations [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on code in PR #9996:
URL: https://github.com/apache/inlong/pull/9996#discussion_r1568171528
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/OperationType.java:
##########
@@ -35,5 +35,18 @@ public enum OperationType {
GET,
- LIST
+ LIST,
+
+ SUSPEND,
+
+ START;
+
+ public static OperationType forOperationType(String type) {
+ for (OperationType operationType : values()) {
+ if (operationType.name().equals(type)) {
Review Comment:
```suggestion
if (operationType.name().equalsIgnoreCase(type)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org