You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/06 17:42:12 UTC
[GitHub] [airflow] Blacksmoke16 opened a new pull request #8737: Add note that the RBAC UI is required for extra links
Blacksmoke16 opened a new pull request #8737:
URL: https://github.com/apache/airflow/pull/8737
After trying unsuccessfully to add extra links based on the [guide](https://airflow.apache.org/docs/stable/howto/define_extra_link.html), I came across some stackoverflow posts, [here](https://stackoverflow.com/a/58615552) and [here](https://stackoverflow.com/a/60253995) mentioning that extra link only work with the `RBAC UI`, which I was not running.
This PR updates the `define_extra_links` howto guide to include a note mentioning extra links only work with the `RBAC UI`.
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Blacksmoke16 commented on pull request #8737: Add note that the RBAC UI is required for extra links
Posted by GitBox <gi...@apache.org>.
Blacksmoke16 commented on pull request #8737:
URL: https://github.com/apache/airflow/pull/8737#issuecomment-625802179
Oops, I borked the merge @ashb. PR is recreated as https://github.com/apache/airflow/pull/8788.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #8737: Add note that the RBAC UI is required for extra links
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #8737:
URL: https://github.com/apache/airflow/pull/8737#issuecomment-625729855
oops, thanks for fixing this.
Can you target this pr against v1-10-stable though please? (it doesn't apply to master branch, as master only has the RBAC UI left)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8737: Add note that the RBAC UI is required for extra links
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #8737:
URL: https://github.com/apache/airflow/pull/8737#issuecomment-624791278
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org