You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Adam Heath <do...@brainfood.com> on 2010/02/14 23:49:35 UTC

latest changes(17 of them)

this set of changes were again managed by git, as I have been saying.
 They were *not* created in sequential order.  I changed their order
at will, even splitting existing commits up.

The tools I used to do this were:

git rebase -i
git rebase --continue
git commit --amend

Here is the log from git, before I starting sending into svn.  You'll
note the dates on the commits are not sequential.

==
commit 44454b7cf172c2f4befecdf9b0322ecb976d9524
Author: Adam Heath <do...@brainfood.com>
Date:   Sun Feb 14 00:24:19 2010 -0600

    Create a JSONWriter.Result class, and change Map/List -> String to use
    that.

commit 1905cf0aa72390f5efb6daa1c1056bb157d81820
Author: Adam Heath <do...@brainfood.com>
Date:   Sat Feb 13 22:57:55 2010 -0600

    StringToEnum conversions now go thru the creation system.

commit 3d1366e1dea1e7a771f527fb1a438bbc1fb5ad6d
Author: Adam Heath <do...@brainfood.com>
Date:   Fri Feb 12 16:14:38 2010 -0600

    Implement a creation framework; this allows creaters to provide
    optimized versions of converters.

commit eab02dd69b234d7a4b56d68575fafd1afd172f6b
Author: Adam Heath <do...@brainfood.com>
Date:   Fri Feb 12 13:49:38 2010 -0600

    Fix several generics warnings.

commit a6a87ee786dbb497050bb0c0c5f98465f9957482
Author: Adam Heath <do...@brainfood.com>
Date:   Fri Feb 12 13:00:35 2010 -0600

    Improve the targeted class convert methods, to have a more strict
    generics type.

commit 46c0d3766861865cbf08f39557e512c842046b08
Author: Adam Heath <do...@brainfood.com>
Date:   Sat Feb 13 19:14:07 2010 -0600

    The abstract Converters now implement ConverterLoader, and their
    register calls to were moved to loadConverters().

commit 2a6b290a79a893637313f66dde6a0303596317af
Author: Adam Heath <do...@brainfood.com>
Date:   Sat Feb 13 19:01:40 2010 -0600

    In loadConverters, if the contained class implements ConverterLoader,
    call it's loadConverters method.
commit 1d2a480bd4f34e278e957a76346f75803fb16348
Author: Adam Heath <do...@brainfood.com>
Date:   Sat Feb 13 19:25:34 2010 -0600

    Make the enum converters extend AbstractConverter.

commit a09af01e086afad08bef4da9df1800a644eed0e3
Author: Adam Heath <do...@brainfood.com>
Date:   Sun Feb 14 16:26:51 2010 -0600

    Protect against public classes with non-public constructors.

commit 0b2731e56864a833302a66b1901d22b8a449f4fa
Author: Adam Heath <do...@brainfood.com>
Date:   Sat Feb 13 19:24:53 2010 -0600

    getSourceClass and getTargetClass are no longer final.

commit 3825ffa3eb2172b14dfec352533d1840ff776538
Author: Adam Heath <do...@brainfood.com>
Date:   Sun Feb 14 13:26:43 2010 -0600

    Make AbstractLocalizedConverter extend AbstractConverter.

commit 077e9d6b99d973c5e9041446952534520b35e712
Author: Adam Heath <do...@brainfood.com>
Date:   Sun Feb 14 13:23:58 2010 -0600

    Make AbstractLocalizedConverter more like AbstractConverter.

commit 9b42ad49e8835cb5fc9fe2ce16d4cc404511589b
Author: Adam Heath <do...@brainfood.com>
Date:   Sat Feb 13 14:26:30 2010 -0600

    Remove checkExtendsImplements; in actuality, each converter should
    handle this itself.

commit 7c53d5a6a7dad5047bef0525ac293331666475c7
Author: Adam Heath <do...@brainfood.com>
Date:   Sat Feb 13 22:27:50 2010 -0600

    Implement unsynchronized(non-blocking) access to converterMap and
    noConversion.


commit 7860b87184a133c8460e5302d5180e8bdc19e623
Author: Adam Heath <do...@brainfood.com>
Date:   Sat Feb 13 16:00:21 2010 -0600

    Remove temporary values variable in getConverter.

commit dec8acd5877efd9f6f4d3a783ccb752f506ade78
Author: Adam Heath <do...@brainfood.com>
Date:   Sun Feb 14 16:18:21 2010 -0600

    Use generics for loop in loadContainedConverters.

commit 5a971798c00bfe999d26b13b572c91648b388207
Author: Adam Heath <do...@brainfood.com>
Date:   Sat Feb 13 10:56:19 2010 -0600

    Remove debug print statement.
==

Re: latest changes(17 of them)

Posted by Ashish Vijaywargiya <vi...@gmail.com>.
This post is not relevant to the work that you have done Adam.
But I am sharing an article if anybody using Eclipse wanted to use
GIT. http://alblue.blogspot.com/2010/02/git-for-eclipse-users.html

--
Ashish

On Mon, Feb 15, 2010 at 4:19 AM, Adam Heath <do...@brainfood.com> wrote:
> this set of changes were again managed by git, as I have been saying.
>  They were *not* created in sequential order.  I changed their order
> at will, even splitting existing commits up.
>
> The tools I used to do this were:
>
> git rebase -i
> git rebase --continue
> git commit --amend
>
> Here is the log from git, before I starting sending into svn.  You'll
> note the dates on the commits are not sequential.
>
> ==
> commit 44454b7cf172c2f4befecdf9b0322ecb976d9524
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sun Feb 14 00:24:19 2010 -0600
>
>    Create a JSONWriter.Result class, and change Map/List -> String to use
>    that.
>
> commit 1905cf0aa72390f5efb6daa1c1056bb157d81820
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 22:57:55 2010 -0600
>
>    StringToEnum conversions now go thru the creation system.
>
> commit 3d1366e1dea1e7a771f527fb1a438bbc1fb5ad6d
> Author: Adam Heath <do...@brainfood.com>
> Date:   Fri Feb 12 16:14:38 2010 -0600
>
>    Implement a creation framework; this allows creaters to provide
>    optimized versions of converters.
>
> commit eab02dd69b234d7a4b56d68575fafd1afd172f6b
> Author: Adam Heath <do...@brainfood.com>
> Date:   Fri Feb 12 13:49:38 2010 -0600
>
>    Fix several generics warnings.
>
> commit a6a87ee786dbb497050bb0c0c5f98465f9957482
> Author: Adam Heath <do...@brainfood.com>
> Date:   Fri Feb 12 13:00:35 2010 -0600
>
>    Improve the targeted class convert methods, to have a more strict
>    generics type.
>
> commit 46c0d3766861865cbf08f39557e512c842046b08
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 19:14:07 2010 -0600
>
>    The abstract Converters now implement ConverterLoader, and their
>    register calls to were moved to loadConverters().
>
> commit 2a6b290a79a893637313f66dde6a0303596317af
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 19:01:40 2010 -0600
>
>    In loadConverters, if the contained class implements ConverterLoader,
>    call it's loadConverters method.
> commit 1d2a480bd4f34e278e957a76346f75803fb16348
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 19:25:34 2010 -0600
>
>    Make the enum converters extend AbstractConverter.
>
> commit a09af01e086afad08bef4da9df1800a644eed0e3
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sun Feb 14 16:26:51 2010 -0600
>
>    Protect against public classes with non-public constructors.
>
> commit 0b2731e56864a833302a66b1901d22b8a449f4fa
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 19:24:53 2010 -0600
>
>    getSourceClass and getTargetClass are no longer final.
>
> commit 3825ffa3eb2172b14dfec352533d1840ff776538
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sun Feb 14 13:26:43 2010 -0600
>
>    Make AbstractLocalizedConverter extend AbstractConverter.
>
> commit 077e9d6b99d973c5e9041446952534520b35e712
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sun Feb 14 13:23:58 2010 -0600
>
>    Make AbstractLocalizedConverter more like AbstractConverter.
>
> commit 9b42ad49e8835cb5fc9fe2ce16d4cc404511589b
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 14:26:30 2010 -0600
>
>    Remove checkExtendsImplements; in actuality, each converter should
>    handle this itself.
>
> commit 7c53d5a6a7dad5047bef0525ac293331666475c7
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 22:27:50 2010 -0600
>
>    Implement unsynchronized(non-blocking) access to converterMap and
>    noConversion.
>
>
> commit 7860b87184a133c8460e5302d5180e8bdc19e623
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 16:00:21 2010 -0600
>
>    Remove temporary values variable in getConverter.
>
> commit dec8acd5877efd9f6f4d3a783ccb752f506ade78
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sun Feb 14 16:18:21 2010 -0600
>
>    Use generics for loop in loadContainedConverters.
>
> commit 5a971798c00bfe999d26b13b572c91648b388207
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 10:56:19 2010 -0600
>
>    Remove debug print statement.
> ==
>

Re: latest changes(17 of them)

Posted by Adrian Crum <ad...@yahoo.com>.
Adam,

Thank you for all of your work on this!

-Adrian

--- On Sun, 2/14/10, Adam Heath <do...@brainfood.com> wrote:

> From: Adam Heath <do...@brainfood.com>
> Subject: latest changes(17 of them)
> To: dev@ofbiz.apache.org
> Date: Sunday, February 14, 2010, 2:49 PM
> this set of changes were again
> managed by git, as I have been saying.
>  They were *not* created in sequential order.  I
> changed their order
> at will, even splitting existing commits up.
> 
> The tools I used to do this were:
> 
> git rebase -i
> git rebase --continue
> git commit --amend
> 
> Here is the log from git, before I starting sending into
> svn.  You'll
> note the dates on the commits are not sequential.
> 
> ==
> commit 44454b7cf172c2f4befecdf9b0322ecb976d9524
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sun Feb 14 00:24:19 2010 -0600
> 
>     Create a JSONWriter.Result class, and change
> Map/List -> String to use
>     that.
> 
> commit 1905cf0aa72390f5efb6daa1c1056bb157d81820
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 22:57:55 2010 -0600
> 
>     StringToEnum conversions now go thru the
> creation system.
> 
> commit 3d1366e1dea1e7a771f527fb1a438bbc1fb5ad6d
> Author: Adam Heath <do...@brainfood.com>
> Date:   Fri Feb 12 16:14:38 2010 -0600
> 
>     Implement a creation framework; this allows
> creaters to provide
>     optimized versions of converters.
> 
> commit eab02dd69b234d7a4b56d68575fafd1afd172f6b
> Author: Adam Heath <do...@brainfood.com>
> Date:   Fri Feb 12 13:49:38 2010 -0600
> 
>     Fix several generics warnings.
> 
> commit a6a87ee786dbb497050bb0c0c5f98465f9957482
> Author: Adam Heath <do...@brainfood.com>
> Date:   Fri Feb 12 13:00:35 2010 -0600
> 
>     Improve the targeted class convert methods,
> to have a more strict
>     generics type.
> 
> commit 46c0d3766861865cbf08f39557e512c842046b08
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 19:14:07 2010 -0600
> 
>     The abstract Converters now implement
> ConverterLoader, and their
>     register calls to were moved to
> loadConverters().
> 
> commit 2a6b290a79a893637313f66dde6a0303596317af
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 19:01:40 2010 -0600
> 
>     In loadConverters, if the contained class
> implements ConverterLoader,
>     call it's loadConverters method.
> commit 1d2a480bd4f34e278e957a76346f75803fb16348
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 19:25:34 2010 -0600
> 
>     Make the enum converters extend
> AbstractConverter.
> 
> commit a09af01e086afad08bef4da9df1800a644eed0e3
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sun Feb 14 16:26:51 2010 -0600
> 
>     Protect against public classes with
> non-public constructors.
> 
> commit 0b2731e56864a833302a66b1901d22b8a449f4fa
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 19:24:53 2010 -0600
> 
>     getSourceClass and getTargetClass are no
> longer final.
> 
> commit 3825ffa3eb2172b14dfec352533d1840ff776538
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sun Feb 14 13:26:43 2010 -0600
> 
>     Make AbstractLocalizedConverter extend
> AbstractConverter.
> 
> commit 077e9d6b99d973c5e9041446952534520b35e712
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sun Feb 14 13:23:58 2010 -0600
> 
>     Make AbstractLocalizedConverter more like
> AbstractConverter.
> 
> commit 9b42ad49e8835cb5fc9fe2ce16d4cc404511589b
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 14:26:30 2010 -0600
> 
>     Remove checkExtendsImplements; in actuality,
> each converter should
>     handle this itself.
> 
> commit 7c53d5a6a7dad5047bef0525ac293331666475c7
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 22:27:50 2010 -0600
> 
>     Implement unsynchronized(non-blocking) access
> to converterMap and
>     noConversion.
> 
> 
> commit 7860b87184a133c8460e5302d5180e8bdc19e623
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 16:00:21 2010 -0600
> 
>     Remove temporary values variable in
> getConverter.
> 
> commit dec8acd5877efd9f6f4d3a783ccb752f506ade78
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sun Feb 14 16:18:21 2010 -0600
> 
>     Use generics for loop in
> loadContainedConverters.
> 
> commit 5a971798c00bfe999d26b13b572c91648b388207
> Author: Adam Heath <do...@brainfood.com>
> Date:   Sat Feb 13 10:56:19 2010 -0600
> 
>     Remove debug print statement.
> ==
>