You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/12 20:25:49 UTC

[GitHub] [incubator-superset] serenajiang opened a new pull request #8032: Fix bug where lists in queries cannot contain multiple types

serenajiang opened a new pull request #8032: Fix bug where lists in queries cannot contain multiple types
URL: https://github.com/apache/incubator-superset/pull/8032
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Use `set` instead of `sorted` to check equality of lists to allow for lists in queries to contain different types.
   
   ### TEST PLAN
   Edited `test_merge_extra_filters_ignores_equal_filters` to include a test case for a list containing different types. Passes all tests.
   
   ### REVIEWERS
   @etr2460 @john-bodley @michellethomas 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org