You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2018/01/26 11:20:37 UTC

[11/33] kylin git commit: KYLIN-3144, adopt Collections.emptyList() for empty list values.

KYLIN-3144, adopt Collections.emptyList() for empty list values.


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/98b1047f
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/98b1047f
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/98b1047f

Branch: refs/heads/sync
Commit: 98b1047fe9fd7f1c66c78fc8d4324c083ba8c9f2
Parents: 19381d3
Author: tttMelody <24...@qq.com>
Authored: Mon Jan 8 19:18:24 2018 +0800
Committer: Li Yang <li...@apache.org>
Committed: Fri Jan 26 17:46:00 2018 +0800

----------------------------------------------------------------------
 .../main/java/org/apache/kylin/rest/service/HybridService.java  | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/98b1047f/server-base/src/main/java/org/apache/kylin/rest/service/HybridService.java
----------------------------------------------------------------------
diff --git a/server-base/src/main/java/org/apache/kylin/rest/service/HybridService.java b/server-base/src/main/java/org/apache/kylin/rest/service/HybridService.java
index 912923a..de20e7c 100644
--- a/server-base/src/main/java/org/apache/kylin/rest/service/HybridService.java
+++ b/server-base/src/main/java/org/apache/kylin/rest/service/HybridService.java
@@ -19,6 +19,7 @@
 package org.apache.kylin.rest.service;
 
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 
 import org.apache.commons.lang.StringUtils;
@@ -119,7 +120,7 @@ public class HybridService extends BasicService {
         if (StringUtils.isEmpty(projectName)) {
             hybridsInProject = new ArrayList(getHybridManager().listHybridInstances());
         } else if (project == null) {
-            return new ArrayList<>();
+            return Collections.emptyList();
         } else {
             List<RealizationEntry> realizationEntries = project.getRealizationEntries(RealizationType.HYBRID);
             if (realizationEntries != null) {
@@ -134,7 +135,7 @@ public class HybridService extends BasicService {
         if (StringUtils.isEmpty(modelName)) {
             return hybridsInProject;
         } else if (model == null) {
-            return new ArrayList<>();
+            return Collections.emptyList();
         } else {
             List<HybridInstance> hybridsInModel = new ArrayList<HybridInstance>();
             for (HybridInstance hybridInstance : hybridsInProject) {