You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "beiwei30 (GitHub)" <gi...@apache.org> on 2019/02/19 08:58:51 UTC

[GitHub] [incubator-dubbo] beiwei30 opened pull request #3505: fix issue#1293: A question for ReferenceConfigCache.

## What is the purpose of the change

fix issue#1293: A question for ReferenceConfigCache.

## Brief changelog

XXXXX

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3505 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3505: fix issue#1293: A question for ReferenceConfigCache.

Posted by "codecov-io (GitHub)" <gi...@apache.org>.

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3505?src=pr&el=h1) Report
> Merging [#3505](https://codecov.io/gh/apache/incubator-dubbo/pull/3505?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/9031a4c20455ba16a63233f10783a55915afcd9b?src=pr&el=desc) will **increase** coverage by `0.76%`.
> The diff coverage is `50%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3505/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3505?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3505      +/-   ##
============================================
+ Coverage     63.37%   64.14%   +0.76%     
  Complexity       71       71              
============================================
  Files           685      664      -21     
  Lines         30447    28606    -1841     
  Branches       5009     4769     -240     
============================================
- Hits          19297    18348     -949     
+ Misses         8828     8042     -786     
+ Partials       2322     2216     -106
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3505?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/dubbo/config/utils/ReferenceConfigCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3505/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy91dGlscy9SZWZlcmVuY2VDb25maWdDYWNoZS5qYXZh) | `74% <50%> (-1%)` | `0 <0> (ø)` | |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3505/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `61.9% <0%> (-9.53%)` | `0% <0%> (ø)` | |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3505/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `67.21% <0%> (-3.28%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3505/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `47.91% <0%> (-1.05%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3505/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `79.52% <0%> (-0.79%)` | `0% <0%> (ø)` | |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3505/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `57.51% <0%> (-0.38%)` | `0% <0%> (ø)` | |
| [...a/org/apache/dubbo/common/json/ParseException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3505/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vanNvbi9QYXJzZUV4Y2VwdGlvbi5qYXZh) | | | |
| [...o/rpc/protocol/thrift/DubboClassNameGenerator.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3505/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90aHJpZnQvRHViYm9DbGFzc05hbWVHZW5lcmF0b3IuamF2YQ==) | | | |
| [.../java/org/apache/dubbo/common/json/JSONObject.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3505/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vanNvbi9KU09OT2JqZWN0LmphdmE=) | | | |
| [.../java/org/apache/dubbo/common/json/JSONWriter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3505/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vanNvbi9KU09OV3JpdGVyLmphdmE=) | | | |
| ... and [20 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3505/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3505?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3505?src=pr&el=footer). Last update [9031a4c...8494fdc](https://codecov.io/gh/apache/incubator-dubbo/pull/3505?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3505 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lixiaojiee closed pull request #3505: fix issue#1293: A question for ReferenceConfigCache.

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.

[ pull request closed by lixiaojiee ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3505 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org