You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/07/25 19:53:45 UTC

[GitHub] dubee commented on a change in pull request #3903: Manually create user log files

dubee commented on a change in pull request #3903: Manually create user log files
URL: https://github.com/apache/incubator-openwhisk/pull/3903#discussion_r205241345
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/containerpool/logging/DockerToActivationFileLogStore.scala
 ##########
 @@ -75,6 +85,8 @@ class DockerToActivationFileLogStore(system: ActorSystem, destinationDirectory:
    * once the defined limit is reached.
    */
   val bufferSize = 100.MB
+  val perms = java.util.EnumSet.of(OWNER_READ, OWNER_WRITE, GROUP_READ, GROUP_WRITE, OTHERS_READ, OTHERS_WRITE)
+  val attr = PosixFilePermissions.asFileAttribute(perms)
 
 Review comment:
   The permissions in the current code base are too restrictive. Perhaps the `OTHERS_WRITE` can be removed here though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services