You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/01/31 08:27:00 UTC
[jira] [Work logged] (TOMEE-2756) Typo in the DeploymentsResolver causes excluding all URLs
[ https://issues.apache.org/jira/browse/TOMEE-2756?focusedWorklogId=842463&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842463 ]
ASF GitHub Bot logged work on TOMEE-2756:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/23 08:26
Start Date: 31/Jan/23 08:26
Worklog Time Spent: 10m
Work Description: rzo1 closed pull request #624: TOMEE-2756 - Fix typo in excluding URLs in the DeploymentResolver
URL: https://github.com/apache/tomee/pull/624
Issue Time Tracking
-------------------
Worklog Id: (was: 842463)
Remaining Estimate: 5m (was: 0.25h)
Time Spent: 10m
> Typo in the DeploymentsResolver causes excluding all URLs
> ---------------------------------------------------------
>
> Key: TOMEE-2756
> URL: https://issues.apache.org/jira/browse/TOMEE-2756
> Project: TomEE
> Issue Type: Bug
> Components: TomEE Core Server
> Affects Versions: 7.0.5
> Environment: Ubuntu 18.04, Embedded TomEE 7.0.5
> Reporter: RomanKa
> Priority: Major
> Original Estimate: 0.25h
> Time Spent: 10m
> Remaining Estimate: 5m
>
> In the project: openejb-core
> Is in the package: org.apache.openejb.config
> Class: DeploymentsResolver
> Method: loadFromClasspath
> Line: 264
> There is typo there from refactoring done 5 years ago, which prevent us from upgrading.
> Current code:
> {code:java}
> UrlSet unchecked = new UrlSet(); if (!searchResult.filterDescriptors) {
> unchecked = NewLoaderLogic.applyBuiltinExcludes(searchResult.prefiltered.exclude(searchResult.prefiltered));
> if (searchResult.filterSystemApps) {
> unchecked = unchecked.exclude(".*/openejb-[^/]+(.(jar|ear|war)(./)?|/target/classes/?)");
> }
> processUrls("DeploymentsResolver2", unchecked.getUrls(), classLoader, EnumSet.allOf(RequireDescriptors.class), jarList);
> } {code}
> In the exclude should be urlSet instead of prefiltered, otherwice all URL are excluded:
> {code:java}
> unchecked = NewLoaderLogic.applyBuiltinExcludes(searchResult.prefiltered.exclude(searchResult.urlSet));
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)