You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 21:11:36 UTC

[PR] [ISSUE-3788][test] Deepen ProxyConsumerResolverTest with blank-instance cache share, address filtering and running-info fallback [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3788:
URL: https://github.com/apache/rocketmq-dashboard/pull/3788

   ### Motivation
   
   The existing `ProxyConsumerResolverTest` covers discovery derivation, caching, transient retry and the connection-query null degradation, but three guard paths were unverified: the shared cache key for blank instance ids, the filtering of blank client addresses during discovery, and the running-info fallback when no proxy is discovered.
   
   ### Changes
   
   - `discoverProxyAddressesShouldShareCacheForBlankInstanceKeys`: null and whitespace-only instance ids map to the same default cache key, so the second lookup is served from cache.
   - `discoverProxyAddressesShouldSkipBlankClientAddresses`: entries with null or whitespace-only client addresses are filtered out, leaving only valid proxy remoting addresses.
   - `resolveConsumerRunningInfoShouldReturnNullWhenNoProxyDiscovered`: a discovery failure degrades the running-info query to null so the caller can fall back to the broker path.
   
   ### Verification
   
   ```
   mvn -B test -Dtest=ProxyConsumerResolverTest
   [INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
   [INFO] BUILD SUCCESS
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE-3788][test] Deepen ProxyConsumerResolverTest with blank-instance cache share, address filtering and running-info fallback [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3788: [ISSUE-3788][test] Deepen ProxyConsumerResolverTest with blank-instance cache share, address filtering and running-info fallback
URL: https://github.com/apache/rocketmq-dashboard/pull/3788


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org