You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/07/28 14:51:17 UTC
[GitHub] [drill] jnturton opened a new pull request, #2615: DRILL-8273: Complex typed columns cannot be made implicit
jnturton opened a new pull request, #2615:
URL: https://github.com/apache/drill/pull/2615
# [DRILL-8273](https://issues.apache.org/jira/browse/DRILL-8273): Complex typed columns cannot be made implicit
## Description
A number of column metadata implementations drop column properties, including the wildcard exclusion property, when cloned with cloneEmpty. This PR makes those cloneEmpty methods copy the column properties too.
## Documentation
N/A
## Testing
New additions in TestTupleProjection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] paul-rogers commented on pull request #2615: DRILL-8273: Complex typed columns cannot be made implicit
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on PR #2615:
URL: https://github.com/apache/drill/pull/2615#issuecomment-1200668136
Jumping in a bit late to this one. It is generally a good idea to include unit tests with all changes. Can we add such tests in a subsequent PR?
Since implicit columns affect wildcard expansion, it would be good to include unit tests to ensure things work as intended. Such tests can be added to, or based upon, the existing projection tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton commented on pull request #2615: DRILL-8273: Complex typed columns cannot be made implicit
Posted by GitBox <gi...@apache.org>.
jnturton commented on PR #2615:
URL: https://github.com/apache/drill/pull/2615#issuecomment-1200704890
Nice to see you @paul-rogers! I did expand [TestTupleProjection.java](https://github.com/apache/drill/pull/2615/files#diff-cacd24c51a19207bf60b8bd8aa9d13b729043cceb2187eb5b4368a855f95e67c) in this PR to check the expected behaviour. I added only simple checks there but this PR also does not introduce any complex logic...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton merged pull request #2615: DRILL-8273: Complex typed columns cannot be made implicit
Posted by GitBox <gi...@apache.org>.
jnturton merged PR #2615:
URL: https://github.com/apache/drill/pull/2615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org