You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Jakub Bartecek <no...@github.com> on 2015/05/04 16:49:38 UTC
[jclouds-labs] Add option to remove a volume, when removing docker
container (#170)
jbartece wants to merge 1 commit into jclouds:master from jbartece:removeVolume:
It would be great, if you could backport it to 1.9.x branch ;-)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/170
-- Commit Summary --
* Add option to remove a volume, when removing docker container
-- File Changes --
M docker/src/main/java/org/jclouds/docker/options/RemoveContainerOptions.java (19)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/170.patch
https://github.com/jclouds/jclouds-labs/pull/170.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/170
Re: [jclouds-labs] Add option to remove a volume, when removing
docker container (#170)
Posted by Ignasi Barrera <no...@github.com>.
Just one minor comment. Thanks @jbartece!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/170#issuecomment-98769861
Re: [jclouds-labs] Add option to remove a volume, when removing
docker container (#170)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -29,6 +29,17 @@ public RemoveContainerOptions force(Boolean force) {
> this.queryParameters.put("force", force.toString());
> return this;
> }
> +
> + /**
> + * Remove the volumes associated to the container
> + *
> + * @param volume If set to true the volume associated to the container will be removed.
> + * Otherwise it will not be removed.
> + */
> + public RemoveContainerOptions volume(Boolean volume) {
Change the parameter to be a primitive as it does not make sense to pass a `null` value here. It could throw a NPE in the next line.
Could you also change the existing methods to use a `boolean` primitive too?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/170/files#r29597704
Re: [jclouds-labs] Add option to remove a volume, when removing
docker container (#170)
Posted by Jakub Bartecek <no...@github.com>.
> @@ -29,6 +29,17 @@ public RemoveContainerOptions force(Boolean force) {
> this.queryParameters.put("force", force.toString());
> return this;
> }
> +
> + /**
> + * Remove the volumes associated to the container
> + *
> + * @param volume If set to true the volume associated to the container will be removed.
> + * Otherwise it will not be removed.
> + */
> + public RemoveContainerOptions volume(Boolean volume) {
OK. I'll change it
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/170/files#r29648052