You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "echobravopapa (GitHub)" <gi...@apache.org> on 2018/10/05 14:49:12 UTC
[GitHub] [geode-native] echobravopapa opened pull request #369:
GEODE-5638: Organize/Cleanup the geode-native project structure
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#369: GEODE-5638: Organize/Cleanup the geode-native project structure
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
This is line should be deleted.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#369: GEODE-5638: Organize/Cleanup the geode-native project structure
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Do we really need to add this whitespace here and the next file. If not then these two files would have no changes.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on pull request #369:
GEODE-5638: Organize/Cleanup the geode-native project structure
Posted by "mmartell (GitHub)" <gi...@apache.org>.
done.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] echobravopapa commented on pull request #369:
GEODE-5638: Organize/Cleanup the geode-native project structure
Posted by "echobravopapa (GitHub)" <gi...@apache.org>.
This is a partial conversion to using `CMAKE_DOTNET_TARGET_FRAMEWORK_VERSION` , there are some remaining csproj.in files belonging to `cli` test framework that will be addressed in https://issues.apache.org/jira/browse/GEODE-5818 until then we need both
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#369: GEODE-5638: Organize/Cleanup the geode-native project structure
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
The project GUID should not be in here as each time the project is generated the GUID will change.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on pull request #369:
GEODE-5638: Organize/Cleanup the geode-native project structure
Posted by "mmartell (GitHub)" <gi...@apache.org>.
done.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#369: GEODE-5638: Organize/Cleanup the geode-native project structure
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Remove GUID
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell closed pull request #369:
GEODE-5638: Organize/Cleanup the geode-native project structure
Posted by "mmartell (GitHub)" <gi...@apache.org>.
[ pull request closed by mmartell ]
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on pull request #369:
GEODE-5638: Organize/Cleanup the geode-native project structure
Posted by "mmartell (GitHub)" <gi...@apache.org>.
done.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on pull request #369:
GEODE-5638: Organize/Cleanup the geode-native project structure
Posted by "mmartell (GitHub)" <gi...@apache.org>.
@pivotal-jbarrett how's this look now?
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org