You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Ernest Burghardt <eb...@pivotal.io> on 2020/03/25 21:11:53 UTC
[VOTE] Apache Geode 1.12.0.RC1
Hello Geode Dev Community,
This is a release candidate for Apache Geode version 1.12.0.RC1.
Thanks to all the community members for their contributions to this release!
Please do a review and give your feedback, including the checks you
performed.
Voting deadline:
3PM PST Mon, March 30 2020.
Please note that we are voting upon the source tag:
rel/v1.12.0.RC1
Release notes:
https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.12.0
Source and binary distributions:
https://dist.apache.org/repos/dist/dev/geode/1.12.0.RC1/
Maven staging repo:
https://repository.apache.org/content/repositories/orgapachegeode-1065
GitHub:
https://github.com/apache/geode/tree/rel/v1.12.0.RC1
https://github.com/apache/geode-examples/tree/rel/v1.12.0.RC1
https://github.com/apache/geode-native/tree/rel/v1.12.0.RC1
https://github.com/apache/geode-benchmarks/tree/rel/v1.12.0.RC1
Pipelines:
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-main
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-rc
Geode's KEYS file containing PGP keys we use to sign the release:
https://github.com/apache/geode/blob/develop/KEYS
Command to run geode-examples:
./gradlew -PgeodeReleaseUrl=
https://dist.apache.org/repos/dist/dev/geode/1.12.0.RC1
-PgeodeRepositoryUrl=
https://repository.apache.org/content/repositories/orgapachegeode-1065
build runAll
Regards
Ernie Burghardt
Re: [VOTE] Apache Geode 1.12.0.RC1
Posted by Ernest Burghardt <eb...@pivotal.io>.
Will work on this list and get a new RC out as soon as possible...
EB
On Thu, Mar 26, 2020 at 8:28 AM Udo Kohlmeyer <ud...@apache.com> wrote:
> Amazing catch Owen!
>
> I'll consider your "-1" as binding and echo it!
>
> Can we recut RC1 and address these issues?
>
> --Udo
>
> On 3/25/20 8:26 PM, Owen Nichols wrote:
> > My vote is non-binding, but I’m a -1 for this RC1. Reasons:
> >
> > i) The geode-examples release branch appears to have been branched from
> master, rather than develop (that's why there are still .zip artifacts).
> Also, I see at least 3 PRs against examples that were mistakenly merged to
> master instead of develop (#89, #91, #92). This needs to be sorted out and
> the branch re-cut correctly.
> >
> > ii) As Dan pointed out, geode-assembly should not be generating an
> artifact, zip or otherwise. I have included a fix for this as part of
> https://github.com/apache/geode/pull/4850
> >
> > iii) As long as we need to make an RC2 anyway, I personally feel that it
> would be nice to align geode-native to its recent milestone
> (build/v10.1.0-build.254 / commit hash 35fcb1a66). The current release
> branch is about half-a-dozen fixes behind this milestone.
> >
> > -Owen
> >
> >> On Mar 25, 2020, at 4:55 PM, Dan Smith <ds...@pivotal.io> wrote:
> >>
> >> geode-assembly-1.12.0.zip does not appear to have any signature files
> >> associated with it. It also looks like it just contains a Dockerfile -
> is
> >> this actually an artifact we want to distribute?
> >>
> >> -Dan
> >>
> >> On Wed, Mar 25, 2020 at 2:12 PM Ernest Burghardt <eburghardt@pivotal.io
> >
> >> wrote:
> >>
> >>> Hello Geode Dev Community,
> >>>
> >>> This is a release candidate for Apache Geode version 1.12.0.RC1.
> >>> Thanks to all the community members for their contributions to this
> >>> release!
> >>>
> >>> Please do a review and give your feedback, including the checks you
> >>> performed.
> >>>
> >>> Voting deadline:
> >>> 3PM PST Mon, March 30 2020.
> >>>
> >>> Please note that we are voting upon the source tag:
> >>> rel/v1.12.0.RC1
> >>>
> >>> Release notes:
> >>>
> >>>
> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.12.0
> >>>
> >>> Source and binary distributions:
> >>> https://dist.apache.org/repos/dist/dev/geode/1.12.0.RC1/
> >>>
> >>> Maven staging repo:
> >>> https://repository.apache.org/content/repositories/orgapachegeode-1065
> >>>
> >>> GitHub:
> >>> https://github.com/apache/geode/tree/rel/v1.12.0.RC1
> >>> https://github.com/apache/geode-examples/tree/rel/v1.12.0.RC1
> >>> https://github.com/apache/geode-native/tree/rel/v1.12.0.RC1
> >>> https://github.com/apache/geode-benchmarks/tree/rel/v1.12.0.RC1
> >>>
> >>> Pipelines:
> >>>
> >>>
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-main
> >>>
> >>>
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-rc
> >>>
> >>> Geode's KEYS file containing PGP keys we use to sign the release:
> >>> https://github.com/apache/geode/blob/develop/KEYS
> >>>
> >>> Command to run geode-examples:
> >>> ./gradlew -PgeodeReleaseUrl=
> >>> https://dist.apache.org/repos/dist/dev/geode/1.12.0.RC1
> >>> -PgeodeRepositoryUrl=
> >>> https://repository.apache.org/content/repositories/orgapachegeode-1065
> >>> build runAll
> >>>
> >>> Regards
> >>> Ernie Burghardt
> >>>
>
Re: [VOTE] Apache Geode 1.12.0.RC1
Posted by Udo Kohlmeyer <ud...@apache.com>.
Amazing catch Owen!
I'll consider your "-1" as binding and echo it!
Can we recut RC1 and address these issues?
--Udo
On 3/25/20 8:26 PM, Owen Nichols wrote:
> My vote is non-binding, but I’m a -1 for this RC1. Reasons:
>
> i) The geode-examples release branch appears to have been branched from master, rather than develop (that's why there are still .zip artifacts). Also, I see at least 3 PRs against examples that were mistakenly merged to master instead of develop (#89, #91, #92). This needs to be sorted out and the branch re-cut correctly.
>
> ii) As Dan pointed out, geode-assembly should not be generating an artifact, zip or otherwise. I have included a fix for this as part of https://github.com/apache/geode/pull/4850
>
> iii) As long as we need to make an RC2 anyway, I personally feel that it would be nice to align geode-native to its recent milestone (build/v10.1.0-build.254 / commit hash 35fcb1a66). The current release branch is about half-a-dozen fixes behind this milestone.
>
> -Owen
>
>> On Mar 25, 2020, at 4:55 PM, Dan Smith <ds...@pivotal.io> wrote:
>>
>> geode-assembly-1.12.0.zip does not appear to have any signature files
>> associated with it. It also looks like it just contains a Dockerfile - is
>> this actually an artifact we want to distribute?
>>
>> -Dan
>>
>> On Wed, Mar 25, 2020 at 2:12 PM Ernest Burghardt <eb...@pivotal.io>
>> wrote:
>>
>>> Hello Geode Dev Community,
>>>
>>> This is a release candidate for Apache Geode version 1.12.0.RC1.
>>> Thanks to all the community members for their contributions to this
>>> release!
>>>
>>> Please do a review and give your feedback, including the checks you
>>> performed.
>>>
>>> Voting deadline:
>>> 3PM PST Mon, March 30 2020.
>>>
>>> Please note that we are voting upon the source tag:
>>> rel/v1.12.0.RC1
>>>
>>> Release notes:
>>>
>>> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.12.0
>>>
>>> Source and binary distributions:
>>> https://dist.apache.org/repos/dist/dev/geode/1.12.0.RC1/
>>>
>>> Maven staging repo:
>>> https://repository.apache.org/content/repositories/orgapachegeode-1065
>>>
>>> GitHub:
>>> https://github.com/apache/geode/tree/rel/v1.12.0.RC1
>>> https://github.com/apache/geode-examples/tree/rel/v1.12.0.RC1
>>> https://github.com/apache/geode-native/tree/rel/v1.12.0.RC1
>>> https://github.com/apache/geode-benchmarks/tree/rel/v1.12.0.RC1
>>>
>>> Pipelines:
>>>
>>> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-main
>>>
>>> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-rc
>>>
>>> Geode's KEYS file containing PGP keys we use to sign the release:
>>> https://github.com/apache/geode/blob/develop/KEYS
>>>
>>> Command to run geode-examples:
>>> ./gradlew -PgeodeReleaseUrl=
>>> https://dist.apache.org/repos/dist/dev/geode/1.12.0.RC1
>>> -PgeodeRepositoryUrl=
>>> https://repository.apache.org/content/repositories/orgapachegeode-1065
>>> build runAll
>>>
>>> Regards
>>> Ernie Burghardt
>>>
Re: [VOTE] Apache Geode 1.12.0.RC1
Posted by Anthony Baker <ab...@pivotal.io>.
Nice! Thanks for the update :-)
> On Mar 26, 2020, at 12:55 PM, John Blum <jb...@pivotal.io> wrote:
>
> SDG builds successfully with the Apache Geode 1.12.0 RC bits.
>
> It is a +1 from me when the rest of the problems are addressed.
>
> SDG build for Apache Geode (next), is here [1].
>
> [1] https://jenkins.spring.io/job/spring-data-geode/job/master-next/
>
>
> On Thu, Mar 26, 2020 at 10:28 AM Anthony Baker <ab...@pivotal.io> wrote:
>
>>>
>>> iii) As long as we need to make an RC2 anyway, I personally feel that it
>> would be nice to align geode-native to its recent milestone
>> (build/v10.1.0-build.254 / commit hash 35fcb1a66). The current release
>> branch is about half-a-dozen fixes behind this milestone.
>>
>> I’m not seeing the milestone you mentioned above. Anyway, is there a
>> critical need to pull in these changes? Given that we’re (hopefully) on
>> the eve of getting this release shipped I’m not sure we should reset the
>> release branch.
>>
>> Anthony
>>
>>
>
> --
> -John
> Spring Data Team
Re: [VOTE] Apache Geode 1.12.0.RC1
Posted by John Blum <jb...@pivotal.io>.
SDG builds successfully with the Apache Geode 1.12.0 RC bits.
It is a +1 from me when the rest of the problems are addressed.
SDG build for Apache Geode (next), is here [1].
[1] https://jenkins.spring.io/job/spring-data-geode/job/master-next/
On Thu, Mar 26, 2020 at 10:28 AM Anthony Baker <ab...@pivotal.io> wrote:
> >
> > iii) As long as we need to make an RC2 anyway, I personally feel that it
> would be nice to align geode-native to its recent milestone
> (build/v10.1.0-build.254 / commit hash 35fcb1a66). The current release
> branch is about half-a-dozen fixes behind this milestone.
>
> I’m not seeing the milestone you mentioned above. Anyway, is there a
> critical need to pull in these changes? Given that we’re (hopefully) on
> the eve of getting this release shipped I’m not sure we should reset the
> release branch.
>
> Anthony
>
>
--
-John
Spring Data Team
Re: [VOTE] Apache Geode 1.12.0.RC1
Posted by Anthony Baker <ab...@pivotal.io>.
>
> iii) As long as we need to make an RC2 anyway, I personally feel that it would be nice to align geode-native to its recent milestone (build/v10.1.0-build.254 / commit hash 35fcb1a66). The current release branch is about half-a-dozen fixes behind this milestone.
I’m not seeing the milestone you mentioned above. Anyway, is there a critical need to pull in these changes? Given that we’re (hopefully) on the eve of getting this release shipped I’m not sure we should reset the release branch.
Anthony
Re: [VOTE] Apache Geode 1.12.0.RC1
Posted by Owen Nichols <on...@pivotal.io>.
My vote is non-binding, but I’m a -1 for this RC1. Reasons:
i) The geode-examples release branch appears to have been branched from master, rather than develop (that's why there are still .zip artifacts). Also, I see at least 3 PRs against examples that were mistakenly merged to master instead of develop (#89, #91, #92). This needs to be sorted out and the branch re-cut correctly.
ii) As Dan pointed out, geode-assembly should not be generating an artifact, zip or otherwise. I have included a fix for this as part of https://github.com/apache/geode/pull/4850
iii) As long as we need to make an RC2 anyway, I personally feel that it would be nice to align geode-native to its recent milestone (build/v10.1.0-build.254 / commit hash 35fcb1a66). The current release branch is about half-a-dozen fixes behind this milestone.
-Owen
> On Mar 25, 2020, at 4:55 PM, Dan Smith <ds...@pivotal.io> wrote:
>
> geode-assembly-1.12.0.zip does not appear to have any signature files
> associated with it. It also looks like it just contains a Dockerfile - is
> this actually an artifact we want to distribute?
>
> -Dan
>
> On Wed, Mar 25, 2020 at 2:12 PM Ernest Burghardt <eb...@pivotal.io>
> wrote:
>
>> Hello Geode Dev Community,
>>
>> This is a release candidate for Apache Geode version 1.12.0.RC1.
>> Thanks to all the community members for their contributions to this
>> release!
>>
>> Please do a review and give your feedback, including the checks you
>> performed.
>>
>> Voting deadline:
>> 3PM PST Mon, March 30 2020.
>>
>> Please note that we are voting upon the source tag:
>> rel/v1.12.0.RC1
>>
>> Release notes:
>>
>> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.12.0
>>
>> Source and binary distributions:
>> https://dist.apache.org/repos/dist/dev/geode/1.12.0.RC1/
>>
>> Maven staging repo:
>> https://repository.apache.org/content/repositories/orgapachegeode-1065
>>
>> GitHub:
>> https://github.com/apache/geode/tree/rel/v1.12.0.RC1
>> https://github.com/apache/geode-examples/tree/rel/v1.12.0.RC1
>> https://github.com/apache/geode-native/tree/rel/v1.12.0.RC1
>> https://github.com/apache/geode-benchmarks/tree/rel/v1.12.0.RC1
>>
>> Pipelines:
>>
>> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-main
>>
>> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-rc
>>
>> Geode's KEYS file containing PGP keys we use to sign the release:
>> https://github.com/apache/geode/blob/develop/KEYS
>>
>> Command to run geode-examples:
>> ./gradlew -PgeodeReleaseUrl=
>> https://dist.apache.org/repos/dist/dev/geode/1.12.0.RC1
>> -PgeodeRepositoryUrl=
>> https://repository.apache.org/content/repositories/orgapachegeode-1065
>> build runAll
>>
>> Regards
>> Ernie Burghardt
>>
Re: [VOTE] Apache Geode 1.12.0.RC1
Posted by Dan Smith <ds...@pivotal.io>.
geode-assembly-1.12.0.zip does not appear to have any signature files
associated with it. It also looks like it just contains a Dockerfile - is
this actually an artifact we want to distribute?
-Dan
On Wed, Mar 25, 2020 at 2:12 PM Ernest Burghardt <eb...@pivotal.io>
wrote:
> Hello Geode Dev Community,
>
> This is a release candidate for Apache Geode version 1.12.0.RC1.
> Thanks to all the community members for their contributions to this
> release!
>
> Please do a review and give your feedback, including the checks you
> performed.
>
> Voting deadline:
> 3PM PST Mon, March 30 2020.
>
> Please note that we are voting upon the source tag:
> rel/v1.12.0.RC1
>
> Release notes:
>
> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.12.0
>
> Source and binary distributions:
> https://dist.apache.org/repos/dist/dev/geode/1.12.0.RC1/
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachegeode-1065
>
> GitHub:
> https://github.com/apache/geode/tree/rel/v1.12.0.RC1
> https://github.com/apache/geode-examples/tree/rel/v1.12.0.RC1
> https://github.com/apache/geode-native/tree/rel/v1.12.0.RC1
> https://github.com/apache/geode-benchmarks/tree/rel/v1.12.0.RC1
>
> Pipelines:
>
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-main
>
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-rc
>
> Geode's KEYS file containing PGP keys we use to sign the release:
> https://github.com/apache/geode/blob/develop/KEYS
>
> Command to run geode-examples:
> ./gradlew -PgeodeReleaseUrl=
> https://dist.apache.org/repos/dist/dev/geode/1.12.0.RC1
> -PgeodeRepositoryUrl=
> https://repository.apache.org/content/repositories/orgapachegeode-1065
> build runAll
>
> Regards
> Ernie Burghardt
>