You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/08/26 05:34:37 UTC
[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #986: SOLR-16337: implement Zk metrics
sonatype-lift[bot] commented on code in PR #986:
URL: https://github.com/apache/solr/pull/986#discussion_r955667146
##########
solr/core/src/java/org/apache/solr/core/ZkContainer.java:
##########
@@ -152,6 +157,23 @@ public void initZooKeeper(final CoreContainer cc, CloudConfig config) {
}
this.zkController = zkController;
+ MetricsMap metricsMap = new MetricsMap(zkController.getZkClient().getMetrics());
Review Comment:
*NULL_DEREFERENCE:* object returned by `getZkClient(zkController)` could be null and is dereferenced at line 160.
---
Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR.
Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands.
---
Was this a good recommendation?
[ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=322753344&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=322753344&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=322753344&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=322753344&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=322753344&lift_comment_rating=5) ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org