[GitHub] [spark] ulysses-you commented on a diff in pull request #36180: [SPARK-38887][SQL] Support switch inner join side for sort merge join

[GitBox <gi...@apache.org>]

ulysses-you commented on code in PR #36180:
URL: https://github.com/apache/spark/pull/36180#discussion_r850076003


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:
##########
@@ -236,8 +236,10 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
 
         def createSortMergeJoin() = {
           if (RowOrdering.isOrderable(leftKeys)) {
-            Some(Seq(joins.SortMergeJoinExec(
-              leftKeys, rightKeys, joinType, nonEquiCond, planLater(left), planLater(right))))
+            val (streamed, buffered) = getSortMergeJoinStreamedAndBufferedSide(joinType, leftKeys,
+              left, right, conf)
+            Some(Seq(joins.SortMergeJoinExec(leftKeys, rightKeys, joinType, nonEquiCond,

Review Comment:
   yeah, I think we should change it back to the original smj output ordering after we switch join side. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org