You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/10 20:13:26 UTC

[GitHub] [beam] ibzib commented on pull request #11972: [BEAM-9852] Do not create data channel for empty timer descriptor.

ibzib commented on pull request #11972:
URL: https://github.com/apache/beam/pull/11972#issuecomment-642232521


   > I'm curious with which runner we will run into this issue.
   
   All portable runners as far as I know (confirmed for Flink, Spark, Dataflow Python streaming).
   
   > The problem is that protos default isn't null but the default empty instance so the check should really be whether it is not the default instance.
   
   Thanks Luke, looks like `message.HasField` is what we want here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org