You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:27 UTC

Re: Review Request 51621: WIP: Made recovered resource allocated as soon as possible.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51621/#review167394
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.

- Joris Van Remoortere


On Oct. 10, 2016, 5:01 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51621/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 5:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jacob Janco, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3078
>     https://issues.apache.org/jira/browse/MESOS-3078
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Please do not review for now as it is WIP.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp c8f9492ee1b69e125a1e841116d22a578a9b524e 
>   src/tests/hierarchical_allocator_tests.cpp 7957873102b3777d47fa9304b85a93d58a746b9d 
>   src/tests/master_allocator_tests.cpp bb94e38d5bb472801366c172cfc036f2eecdcbcb 
>   src/tests/oversubscription_tests.cpp b356fb62a4e068bc171a75a76001c6d0e76af92a 
>   src/tests/persistent_volume_tests.cpp e10a79e9662530e143ccaa2aa2506a4d25158364 
>   src/tests/reservation_endpoints_tests.cpp 7d271085d822e85d27cea5361bfee0d0d91a5691 
>   src/tests/reservation_tests.cpp 6c28ab4557f342134efce0ad7cb174a5adb4dc10 
>   src/tests/slave_tests.cpp bb6216f3f608ce8620a3a11ca716389a906f2d26 
> 
> 
> Diff: https://reviews.apache.org/r/51621/diff/7/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> ```
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*PersistentVolumeTest.BadACL*/*" --verbose --gtest_repeat=20
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*PersistentVolumeTest.GoodACL*/*" --verbose --gtest_repeat=20
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="ReservationEndpointsTest.UnreserveAvailableAndOfferedResources"  --gtest_repeat=20
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="ReservationEndpointsTest.ReserveAvailableAndOfferedResources"  --gtest_repeat=20
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="ReservationTest.ACLMultipleOperations" --verbose  --gtest_repeat=20
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterAllocatorTest/1.RebalancedForUpdatedWeights" --gtest_repeat=30
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.UpdateWeight" --verbose --gtest_repeat=20
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterAllocatorTest/*.SlaveLost" --gtest_repeat=20
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="SlaveTest.ExecutorShutdownGracePeriod" --gtest_repeat=20
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>