You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/18 10:38:15 UTC

[GitHub] [pulsar] 315157973 opened a new pull request #6764: fix Get schema by version can get the deleted schema info #6754

315157973 opened a new pull request #6764: fix Get schema by version can get the deleted schema info #6754
URL: https://github.com/apache/pulsar/pull/6764
 
 
   fix #6754

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] 315157973 commented on issue #6764: fix Get schema by version can get the deleted schema info #6754

Posted by GitBox <gi...@apache.org>.
315157973 commented on issue #6764: fix Get schema by version can get the deleted schema info #6754
URL: https://github.com/apache/pulsar/pull/6764#issuecomment-615892696
 
 
   > We don't need to delete the ledger that stores schemas, the schema delete just add a delete mark in the ledger. There is a method to trim the deleted schemas int the SchemaRegistryServiceImpl. Maybe you can use it directly.
   > https://github.com/apache/pulsar/blob/9d3ab60efddd3f4064789293fd8e9c4d4388b6c7/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java#L317
   
   Thanks,"trimDeletedSchemaAndGetList" is mainly used to get all the schemas and filter out the deleted ones. It is a query method, not really trimming the schema. 
   If there is no need to delete Ledger, then I will remove this piece of code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on issue #6764: fix Get schema by version can get the deleted schema info #6754

Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6764: fix Get schema by version can get the deleted schema info #6754
URL: https://github.com/apache/pulsar/pull/6764#issuecomment-615866842
 
 
   Thanks for the work. @codelipenghui  to take a look.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on a change in pull request #6764: fix Get schema by version can get the deleted schema info #6754

Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #6764: fix Get schema by version can get the deleted schema info #6754
URL: https://github.com/apache/pulsar/pull/6764#discussion_r410695967
 
 

 ##########
 File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicE2ETest.java
 ##########
 @@ -83,6 +53,16 @@
 import org.testng.annotations.DataProvider;
 import org.testng.annotations.Test;
 
+import java.lang.reflect.Field;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.concurrent.*;
 
 Review comment:
   .* should be avoid

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on a change in pull request #6764: fix Get schema by version can get the deleted schema info #6754

Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #6764: fix Get schema by version can get the deleted schema info #6754
URL: https://github.com/apache/pulsar/pull/6764#discussion_r410695997
 
 

 ##########
 File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicE2ETest.java
 ##########
 @@ -83,6 +53,16 @@
 import org.testng.annotations.DataProvider;
 import org.testng.annotations.Test;
 
+import java.lang.reflect.Field;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.concurrent.*;
+
+import static org.testng.Assert.*;
 
 Review comment:
   .* should be avoid
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services