You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/25 21:22:57 UTC

[GitHub] [kafka] cmccabe commented on a change in pull request #10927: MINOR: add MockConfigRepository

cmccabe commented on a change in pull request #10927:
URL: https://github.com/apache/kafka/pull/10927#discussion_r659042611



##########
File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala
##########
@@ -564,7 +563,7 @@ class LogManagerTest {
   @Test
   def testBrokerConfigChangeDeliveredToAllLogs(): Unit = {
     logManager.shutdown()
-    val spyConfigRepository = spy(new CachedConfigRepository)
+    val spyConfigRepository = spy(new MockConfigRepository)

Review comment:
       we want to verify that `topicConfig` was called, and this seemed like the easiest way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org