You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/09/18 07:29:59 UTC
[GitHub] [incubator-shenyu] jinyingxiong opened a new pull request #2100: 版本V2.4.0 Bugfix: 修复monitor组件由于度量指标未注册导致的NullPoint异常
jinyingxiong opened a new pull request #2100:
URL: https://github.com/apache/incubator-shenyu/pull/2100
原因:org.apache.shenyu.plugin.monitor.MonitorPlugin下static代码段中注册了度量名称, 但其注册时机不对, MonitorPlugin加载时MetricsReporter@metricsRegister尚未注入或注入后可以被插件替换
从而导致MonitorPlugin插件运行时MetricsReporter.counterIncrement(LabelNames.REQUEST_TOTAL);(line:50)代码最终会报出org.apache.shenyu.metrics.prometheus.register.PrometheusMetricsRegister.counterIncrement() line:82会报NullPointException
修复方式: org.apache.shenyu.metrics.reporter.MetricsReporter@register(final MetricsRegister metricsRegister)中每次重新注册度量服务时会重新注册MonitorPlugin下static代码段中定义的指标
// Describe your PR here; eg. Fixes #issueNo
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on pull request #2100: 版本V2.4.0 Bugfix: 修复monitor组件由于度量指标未注册导致的NullPoint异常
Posted by GitBox <gi...@apache.org>.
yu199195 commented on pull request #2100:
URL: https://github.com/apache/incubator-shenyu/pull/2100#issuecomment-924539002
pls check ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on pull request #2100: 版本V2.4.0 Bugfix: 修复monitor组件由于度量指标未注册导致的NullPoint异常
Posted by GitBox <gi...@apache.org>.
yu199195 commented on pull request #2100:
URL: https://github.com/apache/incubator-shenyu/pull/2100#issuecomment-922250487
pls used english， see this ：https://shenyu.apache.org/community/issue-pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] jinyingxiong closed pull request #2100: 版本V2.4.0 Bugfix: 修复monitor组件由于度量指标未注册导致的NullPoint异常
Posted by GitBox <gi...@apache.org>.
jinyingxiong closed pull request #2100:
URL: https://github.com/apache/incubator-shenyu/pull/2100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org