[GitHub] spark pull request #18742: [Spark-21542][ML][Python]Python persistence helpe...

[WeichenXu123 <gi...@git.apache.org>]

Github user WeichenXu123 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18742#discussion_r130519716
  
    --- Diff: python/pyspark/ml/param/__init__.py ---
    @@ -375,6 +375,18 @@ def copy(self, extra=None):
             that._defaultParamMap = {}
             return self._copyValues(that, extra)
     
    +    def set(self, param, value):
    +        """
    --- End diff --
    
    We already have `def _set(self, **kwargs)` so does it really need this method ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org