You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by gu...@apache.org on 2017/01/18 17:19:09 UTC
kafka git commit: HOTFIX: ChangeLoggingKeyValueStore.name() returns
null
Repository: kafka
Updated Branches:
refs/heads/trunk ccb183f9f -> 961ebca57
HOTFIX: ChangeLoggingKeyValueStore.name() returns null
This class doesn't need to override this method as it is handled appropriately by the super class
Author: Damian Guy <da...@gmail.com>
Reviewers: Guozhang Wang <wa...@gmail.com>
Closes #2397 from dguy/hotfix-npe-state-store
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/961ebca5
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/961ebca5
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/961ebca5
Branch: refs/heads/trunk
Commit: 961ebca57fdd4f8f84df8cf26a835f07ea1718c9
Parents: ccb183f
Author: Damian Guy <da...@gmail.com>
Authored: Wed Jan 18 09:19:06 2017 -0800
Committer: Guozhang Wang <wa...@gmail.com>
Committed: Wed Jan 18 09:19:06 2017 -0800
----------------------------------------------------------------------
.../streams/state/internals/ChangeLoggingKeyValueStore.java | 7 +------
.../state/internals/ChangeLoggingKeyValueStoreTest.java | 5 +++++
2 files changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/961ebca5/streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueStore.java
----------------------------------------------------------------------
diff --git a/streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueStore.java b/streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueStore.java
index 11cf802..cd63d1a 100644
--- a/streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueStore.java
+++ b/streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueStore.java
@@ -48,12 +48,7 @@ class ChangeLoggingKeyValueStore<K, V> extends WrappedStateStore.AbstractWrapped
this.keySerde = keySerde;
this.valueSerde = valueSerde;
}
-
- @Override
- public String name() {
- return null;
- }
-
+
@SuppressWarnings("unchecked")
@Override
public void init(final ProcessorContext context, final StateStore root) {
http://git-wip-us.apache.org/repos/asf/kafka/blob/961ebca5/streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueStoreTest.java
----------------------------------------------------------------------
diff --git a/streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueStoreTest.java b/streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueStoreTest.java
index 442602c..2dc2017 100644
--- a/streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueStoreTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueStoreTest.java
@@ -200,6 +200,11 @@ public class ChangeLoggingKeyValueStoreTest {
assertThat(store.get(hello), is(nullValue()));
}
+ @Test
+ public void shouldReturnInnerStoreName() throws Exception {
+ assertThat(store.name(), equalTo("kv"));
+ }
+
private String deserializedValueFromInner(final String key) {
return valueSerde.deserializer().deserialize("blah", inner.get(Bytes.wrap(key.getBytes())));
}