[GitHub] [spark] cloud-fan commented on a diff in pull request #37562: [SPARK-40133][SQL][TESTS] Update excluded TPC-DS queries golden files

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #37562:
URL: https://github.com/apache/spark/pull/37562#discussion_r949420020


##########
core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala:
##########
@@ -45,7 +45,6 @@ class SparkThrowableSuite extends SparkFunSuite {
         "core/testOnly *SparkThrowableSuite -- -t \"Error classes are correctly formatted\""
    }}}
    */
-  private val regenerateGoldenFiles: Boolean = System.getenv("SPARK_GENERATE_GOLDEN_FILES") == "1"

Review Comment:
   sorry I may miss some context. What problem do we fix by moving this to `SparkFunSuite`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org