[jira] [Updated] (PHOENIX-2055) Allow view with views to add column

["James Taylor (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PHOENIX-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Taylor updated PHOENIX-2055:
----------------------------------
    Description: Minor follow on to PHOENIX-1504. Due to the potential slowness of the check for whether or not a view has views, especially as the number of views increases (see PHOENIX-2051), I think we should remove the check you added for disallowing adding a column to a view with views. I think it's important to maintain good performance of adding a column to a view, and this check is going to affect adding a column to *any* view, regardless of whether or not it has children. The net effect of allowing the addition of a column to view with views is that all the child views will be considered to have diverged from their parent (which isn't the end of the world). Though somewhat painful, a user could always manually add the column to the child views if desired.  (was: Minor follow on to PHOENIX-1504. Due to the potential slowness of the check for whether or not a view has views, especially as the number of views increases (see PHOENIX-2051), I think we should remove the check you added for disallowing adding a column to a view with views. I think it's important to maintain good performance of adding a column to a view. The net effect of allowing the addition of a column to view with views is that all the child views will be considered to have diverged from their parent (which isn't the end of the world). Though somewhat painful, a user could always manually add the column to the child views if desired.)

> Allow view with views to add column
> -----------------------------------
>
>                 Key: PHOENIX-2055
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2055
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>
> Minor follow on to PHOENIX-1504. Due to the potential slowness of the check for whether or not a view has views, especially as the number of views increases (see PHOENIX-2051), I think we should remove the check you added for disallowing adding a column to a view with views. I think it's important to maintain good performance of adding a column to a view, and this check is going to affect adding a column to *any* view, regardless of whether or not it has children. The net effect of allowing the addition of a column to view with views is that all the child views will be considered to have diverged from their parent (which isn't the end of the world). Though somewhat painful, a user could always manually add the column to the child views if desired.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)