You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2018/02/07 16:28:13 UTC

[incubator-plc4x] branch feature/Beckhoff_ADS_protocol updated: added a generated AMSNetId and AMSPort for source when not supplied

This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch feature/Beckhoff_ADS_protocol
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git


The following commit(s) were added to refs/heads/feature/Beckhoff_ADS_protocol by this push:
     new daafbcd  added a generated AMSNetId and AMSPort for source when not supplied
daafbcd is described below

commit daafbcdf55ca789034e2b9491a925d142e07c3fb
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Wed Feb 7 17:28:09 2018 +0100

    added a generated AMSNetId and AMSPort for source when not supplied
---
 .../apache/plc4x/java/ads/connection/ADSPlcConnection.java   | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/connection/ADSPlcConnection.java b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/connection/ADSPlcConnection.java
index 2ddb8aa..ef584c0 100644
--- a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/connection/ADSPlcConnection.java
+++ b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/connection/ADSPlcConnection.java
@@ -59,11 +59,11 @@ public class ADSPlcConnection extends AbstractPlcConnection implements PlcReader
     private Channel channel;
 
     public ADSPlcConnection(String hostName, AMSNetId targetAmsNetId, AMSPort targetAmsPort) {
-        this(hostName, targetAmsNetId, targetAmsPort, null, null);
+        this(hostName, targetAmsNetId, targetAmsPort, generateAMSNetId(), generateAMSPort());
     }
 
     public ADSPlcConnection(String hostName, Integer port, AMSNetId targetAmsNetId, AMSPort targetAmsPort) {
-        this(hostName, port, targetAmsNetId, targetAmsPort, null, null);
+        this(hostName, port, targetAmsNetId, targetAmsPort, generateAMSNetId(), generateAMSPort());
     }
 
 
@@ -162,4 +162,12 @@ public class ADSPlcConnection extends AbstractPlcConnection implements PlcReader
         return writeFuture;
     }
 
+    private static AMSNetId generateAMSNetId() {
+        return AMSNetId.of("0.0.0.0.0.0");
+    }
+
+    private static AMSPort generateAMSPort() {
+        return AMSPort.of(TCP_PORT);
+    }
+
 }

-- 
To stop receiving notification emails like this one, please contact
sruehl@apache.org.