You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/21 06:25:05 UTC

[GitHub] [flink] JingsongLi commented on a change in pull request #18412: [FLINK-25696][datastream] Introduce MetadataPublisher interface to SinkWriter

JingsongLi commented on a change in pull request #18412:
URL: https://github.com/apache/flink/pull/18412#discussion_r789389668



##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java
##########
@@ -391,6 +401,10 @@ public void onCompletion(RecordMetadata metadata, Exception exception) {
                         () -> throwException(metadata, exception, producer),
                         "Failed to send data to Kafka");
             }
+
+            for (Consumer<RecordMetadata> metadataConsumer : metadataConsumers) {
+                metadataConsumer.accept(metadata);

Review comment:
       Good point, I've summarized below




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org