You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/08/15 13:40:44 UTC

[kudu-CR] Update some comments in Tablet impl and rename a method

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3981

to review the following change.

Change subject: Update some comments in Tablet impl and rename a method
......................................................................

Update some comments in Tablet impl and rename a method

Rename DoCompactionOrFlush() to DoMergeCompactionOrFlush() to be more
specific about what it does.

Change-Id: I3baf4ce119a37bf92d410c4049e308253e238532
---
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
2 files changed, 10 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/3981/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3baf4ce119a37bf92d410c4049e308253e238532
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Update some comments in Tablet impl and rename a method

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Update some comments in Tablet impl and rename a method
......................................................................


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2906/

-- 
To view, visit http://gerrit.cloudera.org:8080/3981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3baf4ce119a37bf92d410c4049e308253e238532
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Update some comments in Tablet impl and rename a method

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Update some comments in Tablet impl and rename a method
......................................................................


Patch Set 5:

Build Started http://104.196.14.100/job/kudu-gerrit/3316/

-- 
To view, visit http://gerrit.cloudera.org:8080/3981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3baf4ce119a37bf92d410c4049e308253e238532
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Update some comments in Tablet impl and rename a method

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Update some comments in Tablet impl and rename a method
......................................................................


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/3219/

-- 
To view, visit http://gerrit.cloudera.org:8080/3981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3baf4ce119a37bf92d410c4049e308253e238532
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Update some comments in Tablet impl and rename a method

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Update some comments in Tablet impl and rename a method
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2903/

-- 
To view, visit http://gerrit.cloudera.org:8080/3981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3baf4ce119a37bf92d410c4049e308253e238532
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Update some comments in Tablet impl and rename a method

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.

Change subject: Update some comments in Tablet impl and rename a method
......................................................................


Update some comments in Tablet impl and rename a method

Rename DoCompactionOrFlush() to DoMergeCompactionOrFlush() to be more
specific about what it does.

Change-Id: I3baf4ce119a37bf92d410c4049e308253e238532
Reviewed-on: http://gerrit.cloudera.org:8080/3981
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
2 files changed, 10 insertions(+), 8 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3baf4ce119a37bf92d410c4049e308253e238532
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Update some comments in Tablet impl and rename a method

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Update some comments in Tablet impl and rename a method
......................................................................


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/3210/

-- 
To view, visit http://gerrit.cloudera.org:8080/3981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3baf4ce119a37bf92d410c4049e308253e238532
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Update some comments in Tablet impl and rename a method

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Update some comments in Tablet impl and rename a method
......................................................................


Patch Set 6: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3baf4ce119a37bf92d410c4049e308253e238532
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Update some comments in Tablet impl and rename a method

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Update some comments in Tablet impl and rename a method
......................................................................


Patch Set 6:

Build Started http://104.196.14.100/job/kudu-gerrit/3323/

-- 
To view, visit http://gerrit.cloudera.org:8080/3981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3baf4ce119a37bf92d410c4049e308253e238532
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No