Re: [PR] CAMEL-23383: Add JFR runtime instrumentation [camel]

["davsclaus (via GitHub)" <gi...@apache.org>]

davsclaus commented on code in PR #25173:
URL: https://github.com/apache/camel/pull/25173#discussion_r3701494022


##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_22.adoc:
##########
@@ -1421,3 +1444,17 @@ entry name could escape the intended directory (Tar Slip / Zip Slip).
 data format and the iterator/splitter modes. The full, unmodified entry name remains available
 so routes that intentionally recreate the archive's directory structure keep working — read it
 from `CamelTarFileEntryName` for tar and from `zipFileName` for zip instead of `CamelFileName`.
+
+=== camel-jfr
+
+`camel-jfr` can now also emit JFR events during message routing, in addition to the
+existing startup instrumentation. This is *opt-in and disabled by default*, so having
+`camel-jfr` on the classpath keeps behaving exactly as it did in 4.21.
+
+Enable it with `camel.main.startup-recorder-runtime-enabled=true`, or programmatically
+with `setRuntimeEnabled(true)` on the `FlightRecorderStartupStepRecorder`. The option is
+read once while the `CamelContext` initializes and cannot be changed afterwards.
+
+`org.apache.camel.spi.StartupStepRecorder` gained the default methods
+`isRuntimeEnabled()` and `setRuntimeEnabled(boolean)`. Both have no-op defaults, so
+existing implementations continue to compile and behave as before.

Review Comment:
   Minor: this file is missing a trailing newline (`\ No newline at end of file` in the diff). Adding one avoids noise in future diffs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org