You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mannoopj (via GitHub)" <gi...@apache.org> on 2023/10/03 18:35:41 UTC
[PR] KAFKA-15532: non active controllers return 0 for ZkWriteBeforelag [kafka]
mannoopj opened a new pull request, #14478:
URL: https://github.com/apache/kafka/pull/14478
Since only the active controller is performing the dual-write to ZK during a migration, it should be the only controller to report the ZkWriteBehindLag metric.
Currently, if the controller fails over during a migration, the previous active controller will incorrectly report its last value for ZkWriteBehindLag forever. Instead, it should report zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15532: non active controllers return 0 for ZkWriteBeforelag [kafka]
Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe merged PR #14478:
URL: https://github.com/apache/kafka/pull/14478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15532: non active controllers return 0 for ZkWriteBeforelag [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #14478:
URL: https://github.com/apache/kafka/pull/14478#discussion_r1344679204
##########
metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java:
##########
@@ -160,8 +160,8 @@ public Long value() {
registry.ifPresent(r -> r.newGauge(ZK_WRITE_BEHIND_LAG, new Gauge<Long>() {
@Override
public Long value() {
- // not in dual-write mode: set metric value to 0
- if (dualWriteOffset() == 0) return 0L;
+ // not in dual-write mode on not an active controller: set metric value to 0
Review Comment:
nit: typo "on" should be "or"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15532: non active controllers return 0 for ZkWriteBeforelag [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #14478:
URL: https://github.com/apache/kafka/pull/14478#issuecomment-1746847899
Changes look good, but there are some failing tests.
<img width="931" alt="image" src="https://github.com/apache/kafka/assets/55116/411b8ee4-fb1c-4537-a578-56550618d1aa">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org