[jira] [Commented] (OFBIZ-11350) Checkstyle improvements

["Wiebke Pätzold (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282385#comment-17282385 ] 

Wiebke Pätzold commented on OFBIZ-11350:
----------------------------------------

Hi all,
while I was fixing some checkstyle errors I noticed the following:

Several checkstyle errors exist under the description " '(' should be on the previous line."
There are several reasons for this:
- A type cast at the beginning of the line (usually checked before with 'instance of')
- The line before had more than 150 characters and is wrapped at a '(' e.g. a mathematical function which is used
How do we proceed with this? My idea would be either to store the type cast before in an own variable or to adapt the checkstyle rules. What are your opinions?

And another point I noticed is in the class EntityFunction.java the checkstyle error "Name (e.g. UPPER) must match pattern '^[a-z][a-zA-Z0-9]*$'" occurs. Here the name of the functions are all in upper case while it should be lower case letters. So it needs a refactoring over all their occurrences. Or what do you think?


> Checkstyle improvements
> -----------------------
>
>                 Key: OFBIZ-11350
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11350
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>
> This is an umbrella task for checkstyle improvements.
> See related discussion on the dev mailinglist: https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)