You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by "korlov42 (via GitHub)" <gi...@apache.org> on 2023/08/17 15:00:51 UTC

[GitHub] [ignite-3] korlov42 opened a new pull request, #2460: IGNITE-20104 Sql. Improve error messages from Sql parser

korlov42 opened a new pull request, #2460:
URL: https://github.com/apache/ignite-3/pull/2460

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] korlov42 merged pull request #2460: IGNITE-20104 Sql. Improve error messages from Sql parser

Posted by "korlov42 (via GitHub)" <gi...@apache.org>.

korlov42 merged PR #2460:
URL: https://github.com/apache/ignite-3/pull/2460


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #2460: IGNITE-20104 Sql. Improve error messages from Sql parser

Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.

ygerzhedovich commented on code in PR #2460:
URL: https://github.com/apache/ignite-3/pull/2460#discussion_r1302829589


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java:
##########
@@ -315,8 +315,6 @@ public void testDecimalLiteral() {
         assertQuery("SELECT CASE WHEN false THEN DECIMAL '1.00' ELSE DECIMAL '0.0' END")
                 .returns(new BigDecimal("0.0")).check();
 
-        assertQuery("SELECT DECIMAL \"10\" FROM (SELECT 1 as decimal) tmp").returns(1).check();

Review Comment:
   Why it has been deleted?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2460: IGNITE-20104 Sql. Improve error messages from Sql parser

Posted by "korlov42 (via GitHub)" <gi...@apache.org>.

korlov42 commented on code in PR #2460:
URL: https://github.com/apache/ignite-3/pull/2460#discussion_r1302864119


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java:
##########
@@ -315,8 +315,6 @@ public void testDecimalLiteral() {
         assertQuery("SELECT CASE WHEN false THEN DECIMAL '1.00' ELSE DECIMAL '0.0' END")
                 .returns(new BigDecimal("0.0")).check();
 
-        assertQuery("SELECT DECIMAL \"10\" FROM (SELECT 1 as decimal) tmp").returns(1).check();

Review Comment:
   this particular case verifies that `DECIMAL \"10\"` is parsed as column name and alias and not like decimal literal. In this patch keyword `DECIMAL` becomes reserved, rendering such construction not possible anymore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org