You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jmeter.apache.org by woonsan <gi...@git.apache.org> on 2017/02/07 21:56:37 UTC

[GitHub] jmeter pull request #264: Bug 60564 - Migrating to SLF4J logger - components...

GitHub user woonsan opened a pull request:

    https://github.com/apache/jmeter/pull/264

    Bug 60564 - Migrating to SLF4J logger - components/config,control,extractor packages.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/woonsan/jmeter feature/bz60564-3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/264.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #264
    
----
commit 5f9f63ddab2ccc8dbcd9627fb18072985246c050
Author: Woonsan Ko <wo...@apache.org>
Date:   2017-02-07T20:56:06Z

    Bug 60564 - Migrating LogKit logger to SLF4J logger - only for
    components/config and components/control packages.

commit 4367faaac75b13ed73d4e58fac0896d21c2e383c
Author: Woonsan Ko <wo...@apache.org>
Date:   2017-02-07T21:45:33Z

    Bug 60564 - Migrating LogKit logger to SLF4J logger - only for
    components/extractor package.

commit a31f05f76a93c43ab1f0bda4d0244f8835dce004
Author: Woonsan Ko <wo...@apache.org>
Date:   2017-02-07T21:46:26Z

    Merge branch 'trunk' into feature/bz60564-3

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request #264: Bug 60564 - Migrating to SLF4J logger - components...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/jmeter/pull/264


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #264: Bug 60564 - Migrating to SLF4J logger - components/config...

Posted by pmouawad <gi...@git.apache.org>.

Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/264
  
    Hi Woonsan,
    Thanks for the PR.
    
    I just modified few lines as per my comment on PR 263
    And in CSV DataSet , a call to file.getAbsolutePath() was wrongly replaced by a var that was not updated.
    Thanks
    
    Regards
    Philippe


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #264: Bug 60564 - Migrating to SLF4J logger - components/config...

Posted by woonsan <gi...@git.apache.org>.

Github user woonsan commented on the issue:

    https://github.com/apache/jmeter/pull/264
  
    @pmouawad Thanks for the review! I totally overlooked the file being recreated. Cheers!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---