You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hive.apache.org by "Mustafa Iman (Jira)" <ji...@apache.org> on 2020/06/06 07:03:00 UTC

[jira] [Commented] (HIVE-23629) Enforce clean findbugs in PRs

    [ https://issues.apache.org/jira/browse/HIVE-23629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127253#comment-17127253 ] 

Mustafa Iman commented on HIVE-23629:
-------------------------------------

[~kgyrtkirk] I create a PR for this. The PR intentionally checks findbugs errors for "hive-shims-common" which contains multiple errors. My intention was to first demonstrate that the check fails the build when findbugs errors is present. After that, I was going to fix the errors in the same PR and merge the PR when tests succeed. The problem is that Jenkins does not pick the Jenkinsfile from my PR as I am not a trusted user. Can you help with this?

> Enforce clean findbugs in PRs
> -----------------------------
>
>                 Key: HIVE-23629
>                 URL: https://issues.apache.org/jira/browse/HIVE-23629
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Mustafa Iman
>            Assignee: Mustafa Iman
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We should start enforcing clean findbugs reports as soon as we fix a module. Otherwise, it will continue collecting findbugs errors. We can add a stage to Jenkins pipeline to enforce findbugs and possibly other checks. It will selectively run findbugs for specified sub modules. Eventually we can get rid of the list and enable findbugs for the whole project.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)