You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Suman Karumuri <sk...@twitter.com> on 2013/12/12 01:44:26 UTC
Review Request 16195: Added a header for the new UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: MESOS-4678
https://issues.apache.org/jira/browse/MESOS-4678
Repository: aurora
Description
-------
Added a basic header for the new UI.
Updated ServletModule accordingly.
Diffs
-----
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION
Diff: https://reviews.apache.org/r/16195/diff/
Testing
-------
Tested using local isolated scheduler.
gradle clean build.
Thanks,
Suman Karumuri
Re: Review Request 16195: Added a home page with a header for the new UI
Posted by Suman Karumuri <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/#review30413
-----------------------------------------------------------
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58204>
This is a landing page with just the navbar. Updated the title and the description to remove any confusion.
- Suman Karumuri
On Dec. 14, 2013, 2:57 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16195/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2013, 2:57 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a home page with basic header for the new UI.
>
> Updated ServletModule accordingly.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
> src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16195/diff/
>
>
> Testing
> -------
>
> Tested using local isolated scheduler.
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16195: Added a home page with a header for the new UI
Posted by Suman Karumuri <su...@gmail.com>.
> On Dec. 16, 2013, 8:10 p.m., Bill Farner wrote:
> > Now that we've straightened out the purpose, i'm wondering if it makes sense to approach from the direction of adding a half-baked page. Would it be more appropriate to wait until the thrift API support is there so we can populate this page?
Sure we can wait. Sent this small review out to make sure I am on the right track implementation wise and also to keep the code reviews small. Will send out the next reviews on this thread then.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/#review30474
-----------------------------------------------------------
On Dec. 16, 2013, 6:37 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16195/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 6:37 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a home page with basic header for the new UI.
>
> Updated ServletModule accordingly.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
> src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16195/diff/
>
>
> Testing
> -------
>
> Tested using local isolated scheduler.
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16195: Added a home page with a header for the new UI
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/#review30474
-----------------------------------------------------------
Now that we've straightened out the purpose, i'm wondering if it makes sense to approach from the direction of adding a half-baked page. Would it be more appropriate to wait until the thrift API support is there so we can populate this page?
- Bill Farner
On Dec. 16, 2013, 6:37 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16195/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 6:37 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a home page with basic header for the new UI.
>
> Updated ServletModule accordingly.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
> src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16195/diff/
>
>
> Testing
> -------
>
> Tested using local isolated scheduler.
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16195: Added a home page with a header for the new UI
Posted by Suman Karumuri <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/
-----------------------------------------------------------
(Updated Dec. 16, 2013, 6:37 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Fixed CR feedback.
Repository: aurora
Description
-------
Added a home page with basic header for the new UI.
Updated ServletModule accordingly.
Diffs (updated)
-----
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION
Diff: https://reviews.apache.org/r/16195/diff/
Testing
-------
Tested using local isolated scheduler.
gradle clean build.
Thanks,
Suman Karumuri
Re: Review Request 16195: Added a home page with a header for the new UI
Posted by Suman Karumuri <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/#review30458
-----------------------------------------------------------
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58272>
fixed.
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58271>
removed.
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58270>
Removed.
- Suman Karumuri
On Dec. 14, 2013, 2:57 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16195/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2013, 2:57 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a home page with basic header for the new UI.
>
> Updated ServletModule accordingly.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
> src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16195/diff/
>
>
> Testing
> -------
>
> Tested using local isolated scheduler.
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16195: Added a home page with a header for the new UI
Posted by Suman Karumuri <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/
-----------------------------------------------------------
(Updated Dec. 14, 2013, 2:57 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Summary (updated)
-----------------
Added a home page with a header for the new UI
Repository: aurora
Description (updated)
-------
Added a home page with basic header for the new UI.
Updated ServletModule accordingly.
Diffs
-----
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION
Diff: https://reviews.apache.org/r/16195/diff/
Testing
-------
Tested using local isolated scheduler.
gradle clean build.
Thanks,
Suman Karumuri
Re: Review Request 16195: Added a header for the new UI
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/#review30404
-----------------------------------------------------------
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58193>
revert — this is more of intellij trying to be helpful. however, it underscores the importance of skimming your review diff before publishing (self-reviewing).
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58194>
remove extra newline
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58195>
Please avoid using "new" qualifier, it just leaves us with something we have to go back and clean up later.
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58196>
I'm confused — is this a landing page or a header? Name suggests one thing, review title suggests another. If it's a landing page, how would you feel about discarding the '.html'?
- Bill Farner
On Dec. 13, 2013, 12:22 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16195/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 12:22 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a basic header for the new UI.
>
> Updated ServletModule accordingly.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
> src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16195/diff/
>
>
> Testing
> -------
>
> Tested using local isolated scheduler.
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16195: Added a header for the new UI
Posted by Suman Karumuri <sk...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/
-----------------------------------------------------------
(Updated Dec. 13, 2013, 12:22 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Repository: aurora
Description
-------
Added a basic header for the new UI.
Updated ServletModule accordingly.
Diffs
-----
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION
Diff: https://reviews.apache.org/r/16195/diff/
Testing
-------
Tested using local isolated scheduler.
gradle clean build.
Thanks,
Suman Karumuri
Re: Review Request 16195: Added a header for the new UI
Posted by Suman Karumuri <sk...@twitter.com>.
> On Dec. 12, 2013, 5:42 p.m., Bill Farner wrote:
> > Please remove bogus bug reference from the review.
Removed. Added it for code review context.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/#review30265
-----------------------------------------------------------
On Dec. 13, 2013, 12:22 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16195/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 12:22 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a basic header for the new UI.
>
> Updated ServletModule accordingly.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
> src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16195/diff/
>
>
> Testing
> -------
>
> Tested using local isolated scheduler.
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16195: Added a header for the new UI
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/#review30265
-----------------------------------------------------------
Please remove bogus bug reference from the review.
- Bill Farner
On Dec. 12, 2013, 12:44 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16195/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2013, 12:44 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: MESOS-4678
> https://issues.apache.org/jira/browse/MESOS-4678
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a basic header for the new UI.
>
> Updated ServletModule accordingly.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
> src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16195/diff/
>
>
> Testing
> -------
>
> Tested using local isolated scheduler.
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>