You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by "soulbird (via GitHub)" <gi...@apache.org> on 2023/02/20 01:48:24 UTC

[GitHub] [apisix] soulbird commented on pull request #8866: feat: use env var instead of plain text for vault token

soulbird commented on PR #8866:
URL: https://github.com/apache/apisix/pull/8866#issuecomment-1436184618

   IMO, just adding a test case for t/secret/vault.t is enough. The test cases under t/plugin seem redundant, don't you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org