You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/01 02:21:52 UTC
[GitHub] [airflow] blag opened a new pull request, #26815: Move a user-facing string to a template for better model-view separation
blag opened a new pull request, #26815:
URL: https://github.com/apache/airflow/pull/26815
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This small PR just tweaks a single function, the single place it's called, and the template. It helps to separate out user-facing strings into templates for better MVC, and more concretely, for possible language translations in the future.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #26815: Move user-facing string to template
Posted by GitBox <gi...@apache.org>.
uranusjr merged PR #26815:
URL: https://github.com/apache/airflow/pull/26815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blag commented on pull request #26815: Move user-facing string to template
Posted by GitBox <gi...@apache.org>.
blag commented on PR #26815:
URL: https://github.com/apache/airflow/pull/26815#issuecomment-1273827966
@uranusjr Thanks for the merge! 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #26815: Move a user-facing string to a template for better model-view separation
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #26815:
URL: https://github.com/apache/airflow/pull/26815#discussion_r986033383
##########
airflow/www/templates/airflow/dags.html:
##########
@@ -308,7 +308,9 @@ <h2>{{ page_title }}</h2>
data-dag-id="{{ dag.dag_id }}"
data-summary="{{ dataset_triggered_next_run_info[dag.dag_id] }}"
>
- {{ dataset_triggered_next_run_info[dag.dag_id] }}
+ {% with %}{% set ds_info = dataset_triggered_next_run_info[dag.dag_id] %}
+ {{ ds_info.ready }} of {{ ds_info.total }} datasets updated
Review Comment:
@ashb and I were talking about changing this text when it is only a single dataset dependency.
It would always say "0 of 1 datasets updated", so maybe it should just show the name of the one dataset it is dependent on. Although I'm unsure if its best to do that in this PR or in a later one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org