You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/11/18 12:13:02 UTC
Review Request 15645: CLOUDSTACK-5194: portable ip - Improving cleanup code
to avoid cascading failures
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15645/
-----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-5194
https://issues.apache.org/jira/browse/CLOUDSTACK-5194
Repository: cloudstack-git
Description
-------
Added code to ensure portable ip range gets deleted successfully after each test case execution, so that successive test cases won't fail while portable ip range creation if one of the test case fails.
Diffs
-----
test/integration/component/test_portable_ip.py 14b6dac
Diff: https://reviews.apache.org/r/15645/diff/
Testing
-------
Tested locally on KVM advanced setup.
Thanks,
Gaurav Aradhye
Re: Review Request 15645: CLOUDSTACK-5194: portable ip - Improving cleanup
code to avoid cascading failures
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15645/#review29102
-----------------------------------------------------------
Commit 67b071beaac34eb5c4427f120ed3f0d5baabb75b in branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=67b071b ]
CLOUDSTACK-5194: portable ip - Improving cleanup code to
avoid cascading failures
- ASF Subversion and Git Services
On Nov. 18, 2013, 11:13 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15645/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 11:13 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5194
> https://issues.apache.org/jira/browse/CLOUDSTACK-5194
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added code to ensure portable ip range gets deleted successfully after each test case execution, so that successive test cases won't fail while portable ip range creation if one of the test case fails.
>
>
> Diffs
> -----
>
> test/integration/component/test_portable_ip.py 14b6dac
>
> Diff: https://reviews.apache.org/r/15645/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 15645: CLOUDSTACK-5194: portable ip - Improving cleanup
code to avoid cascading failures
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15645/#review29100
-----------------------------------------------------------
Commit 85d3be79d0665e1cca050d64982e64fb4008dd0b in branch refs/heads/4.3 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=85d3be7 ]
CLOUDSTACK-5194: portable ip - Improving cleanup code to
avoid cascading failures
- ASF Subversion and Git Services
On Nov. 18, 2013, 11:13 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15645/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 11:13 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5194
> https://issues.apache.org/jira/browse/CLOUDSTACK-5194
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added code to ensure portable ip range gets deleted successfully after each test case execution, so that successive test cases won't fail while portable ip range creation if one of the test case fails.
>
>
> Diffs
> -----
>
> test/integration/component/test_portable_ip.py 14b6dac
>
> Diff: https://reviews.apache.org/r/15645/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 15645: CLOUDSTACK-5194: portable ip - Improving cleanup
code to avoid cascading failures
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15645/#review29099
-----------------------------------------------------------
Commit 465ac16258df78cd6277d480e9319c24897a024c in branch refs/heads/4.2 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=465ac16 ]
CLOUDSTACK-5194: portable ip - Improving cleanup code to
avoid cascading failures
- ASF Subversion and Git Services
On Nov. 18, 2013, 11:13 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15645/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 11:13 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5194
> https://issues.apache.org/jira/browse/CLOUDSTACK-5194
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added code to ensure portable ip range gets deleted successfully after each test case execution, so that successive test cases won't fail while portable ip range creation if one of the test case fails.
>
>
> Diffs
> -----
>
> test/integration/component/test_portable_ip.py 14b6dac
>
> Diff: https://reviews.apache.org/r/15645/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 15645: CLOUDSTACK-5194: portable ip - Improving cleanup
code to avoid cascading failures
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15645/#review29101
-----------------------------------------------------------
Ship it!
Committed to 4.2, 4.3 and master
- Girish Shilamkar
On Nov. 18, 2013, 11:13 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15645/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 11:13 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5194
> https://issues.apache.org/jira/browse/CLOUDSTACK-5194
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added code to ensure portable ip range gets deleted successfully after each test case execution, so that successive test cases won't fail while portable ip range creation if one of the test case fails.
>
>
> Diffs
> -----
>
> test/integration/component/test_portable_ip.py 14b6dac
>
> Diff: https://reviews.apache.org/r/15645/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>