You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@yunikorn.apache.org by "Peter Bacsko (Jira)" <ji...@apache.org> on 2023/08/07 13:35:00 UTC

[jira] [Commented] (YUNIKORN-1903) Add unit tests for GetConfiguration* common/utils.go

    [ https://issues.apache.org/jira/browse/YUNIKORN-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751676#comment-17751676 ] 

Peter Bacsko commented on YUNIKORN-1903:
----------------------------------------

Thanks [~yangpoan] for the PR, merged to master.

> Add unit tests for GetConfiguration* common/utils.go
> ----------------------------------------------------
>
>                 Key: YUNIKORN-1903
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1903
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - common, test - unit
>            Reporter: Wilfred Spiegelenburg
>            Assignee: PoAn Yang
>            Priority: Major
>              Labels: pull-request-available
>
> New functions have been added to read configuration values from the reloaded config map. These utility functions are not tested and should be covered by unit tests. These cases should be tested:
>  * nil safety (if applicable)
>  * key not found
>  * conversion error into requested type
>  * working case



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org