You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2016/05/25 00:20:53 UTC
Review Request 47803: field value could be null,
need to handle this case
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47803/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Bugs: GEODE-1453
https://issues.apache.org/jira/browse/GEODE-1453
Repository: geode
Description
-------
The field value could be null, when creating index, we need to handle it.
Diffs
-----
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxLuceneSerializer.java 3990614
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java a76478c
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java 4ebb9c4
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxFieldMapperJUnitTest.java 278e818
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionFieldMapperJUnitTest.java c187022
Diff: https://reviews.apache.org/r/47803/diff/
Testing
-------
Thanks,
xiaojian zhou
Re: Review Request 47803: field value could be null,
need to handle this case
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47803/#review134667
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On May 25, 2016, 12:20 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47803/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 12:20 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-1453
> https://issues.apache.org/jira/browse/GEODE-1453
>
>
> Repository: geode
>
>
> Description
> -------
>
> The field value could be null, when creating index, we need to handle it.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxLuceneSerializer.java 3990614
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java a76478c
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java 4ebb9c4
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxFieldMapperJUnitTest.java 278e818
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionFieldMapperJUnitTest.java c187022
>
> Diff: https://reviews.apache.org/r/47803/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 47803: field value could be null,
need to handle this case
Posted by Dan Smith <ds...@pivotal.io>.
> On May 25, 2016, 5:56 p.m., anilkumar gingade wrote:
> > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java, line 73
> > <https://reviews.apache.org/r/47803/diff/1/?file=1392951#file1392951line73>
> >
> > This makes the null values to be not indexed....
> >
> > The NULL handling is common in data-stores....Queries looking for null values are common...
> >
> > It looks like there is a ISNULL option in Lucene, we need to invistage to see how we can store null and allow users to query null values...
> >
> > https://forums.alfresco.com/forum/developer-discussions/other-apis/solved-empty-or-null-description-lucene-query-05052014-1521
That cm:isnull thing looks like it's specific to alfresco. I don't think lucene natively supports nulls.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47803/#review134795
-----------------------------------------------------------
On May 25, 2016, 12:20 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47803/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 12:20 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-1453
> https://issues.apache.org/jira/browse/GEODE-1453
>
>
> Repository: geode
>
>
> Description
> -------
>
> The field value could be null, when creating index, we need to handle it.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxLuceneSerializer.java 3990614
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java a76478c
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java 4ebb9c4
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxFieldMapperJUnitTest.java 278e818
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionFieldMapperJUnitTest.java c187022
>
> Diff: https://reviews.apache.org/r/47803/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 47803: field value could be null,
need to handle this case
Posted by anilkumar gingade <ag...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47803/#review134795
-----------------------------------------------------------
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java (line 73)
<https://reviews.apache.org/r/47803/#comment199706>
This makes the null values to be not indexed....
The NULL handling is common in data-stores....Queries looking for null values are common...
It looks like there is a ISNULL option in Lucene, we need to invistage to see how we can store null and allow users to query null values...
https://forums.alfresco.com/forum/developer-discussions/other-apis/solved-empty-or-null-description-lucene-query-05052014-1521
- anilkumar gingade
On May 25, 2016, 12:20 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47803/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 12:20 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-1453
> https://issues.apache.org/jira/browse/GEODE-1453
>
>
> Repository: geode
>
>
> Description
> -------
>
> The field value could be null, when creating index, we need to handle it.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxLuceneSerializer.java 3990614
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java a76478c
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java 4ebb9c4
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxFieldMapperJUnitTest.java 278e818
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionFieldMapperJUnitTest.java c187022
>
> Diff: https://reviews.apache.org/r/47803/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 47803: field value could be null,
need to handle this case
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47803/#review134801
-----------------------------------------------------------
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java (line 73)
<https://reviews.apache.org/r/47803/#comment199714>
If we wanted to do something similar we could change SerializerUtil to detect a null value and stuff a token in, but do we want to do that?
- Jason Huynh
On May 25, 2016, 12:20 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47803/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 12:20 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-1453
> https://issues.apache.org/jira/browse/GEODE-1453
>
>
> Repository: geode
>
>
> Description
> -------
>
> The field value could be null, when creating index, we need to handle it.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxLuceneSerializer.java 3990614
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java a76478c
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java 4ebb9c4
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxFieldMapperJUnitTest.java 278e818
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionFieldMapperJUnitTest.java c187022
>
> Diff: https://reviews.apache.org/r/47803/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>