You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Everett Toews <no...@github.com> on 2013/05/23 03:06:52 UTC

[jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

https://issues.apache.org/jira/browse/JCLOUDS-78
You can merge this Pull Request by running:

  git pull https://github.com/rackspace/jclouds JCLOUDS-78-rax-dns-pagination-fix

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/15

-- Commit Summary --

  * JCLOUDS-78: Fix record pagination problem. Backfill tests.

-- File Changes --

    M apis/rackspace-clouddns/src/main/java/org/jclouds/rackspace/clouddns/v1/functions/RecordsToPagedIterable.java (2)
    M apis/rackspace-clouddns/src/test/java/org/jclouds/rackspace/clouddns/v1/features/DomainApiExpectTest.java (58)
    M apis/rackspace-clouddns/src/test/java/org/jclouds/rackspace/clouddns/v1/features/RecordApiExpectTest.java (20)
    A apis/rackspace-clouddns/src/test/resources/domain-list-page1.json (47)
    A apis/rackspace-clouddns/src/test/resources/domain-list-page2.json (47)
    A apis/rackspace-clouddns/src/test/resources/record-list-page1.json (48)
    A apis/rackspace-clouddns/src/test/resources/record-list-page2.json (48)
    A apis/rackspace-clouddns/src/test/resources/subdomain-list-page1.json (39)
    A apis/rackspace-clouddns/src/test/resources/subdomain-list-page2.json (39)
    A apis/rackspace-clouddns/src/test/resources/subdomain-list.json (33)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/15.patch
https://github.com/jclouds/jclouds/pull/15.diff

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Adrian Cole <no...@github.com>.
+1 proves pagination works!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18344860

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Closing and re-opening to try to poke BuildHive.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18342266

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Everett Toews <no...@github.com>.
Thanks for all the help @demobox !

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18359527

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Here goes the version with [the change](https://github.com/demobox/jclouds/commit/a3e33d3ae13ed24198e864f212abffd42f802a22): https://jclouds.ci.cloudbees.com/job/fix-checkstyle-error/3/console

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18365050

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Now with [that changed too](https://github.com/demobox/jclouds/commit/87adb3666f512249ab5f8f2eb19104e0a47f85dc)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18365943

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Reopened #15.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Hm, looks like BuildHive is triggering again: https://github.com/jclouds/jclouds/pull/16#issuecomment-18353147. Will try *one* more close/re-open cycle here...apologies for any spam!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18353250

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
And one more close/re-open cycle...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18351984

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Closed #15.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Gaul <no...@github.com>.
@demobox good eye!  Do you want to push a fix or should I?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18363818

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Gaul <no...@github.com>.
@demobox I have not seen that error before, seems like an internal Checkstyle error.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18359973

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
> Do you want to push a fix or should I?

@andrewgaul See https://github.com/jclouds/jclouds/issues/17

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18382170

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Testing first: https://jclouds.ci.cloudbees.com/job/fix-checkstyle-error

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18364082

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Closed #15.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Still unhappy. Doesn't appear to be a problem with the license header, though - more that it can't seem to resolve the relative reference to the suppressions file when run directly from the `core` folder. Trying again from top level: https://jclouds.ci.cloudbees.com/job/fix-checkstyle-error/5/console

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18366576

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
> jclouds-java-7-pull-requests #420 FAILURE

Not related to the code - looks like a problem with the Checkstyle config or result processing:
```
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: unable to read /scratch/jenkins/workspace/jclouds-java-7-pull-requests/core/target/checkstyle-checker.xml - unable to parse configuration stream - The processing instruction target matching "[xX][mM][lL]" is not allowed.:19:6
```
@abayer @andrewgaul Look familiar in any way..?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18359785

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Reopened #15.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Everett Toews <no...@github.com>.
Closed #15.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Closed #15.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Everett Toews <no...@github.com>.
@adriancole Thought you might like to give this a review as it's Denominator related and you'll have to do something similar for Route53 (as I understand it).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18318056

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #420](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/420/) FAILURE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18353868

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
@andrewgaul I think it's the [license header](https://github.com/jclouds/jclouds/blob/master/resources/checkstyle.xml). Any way we can try with the header **below** the 
```
<?xml version="1.0" encoding="UTF-8"?>
```
opening line?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18363385

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Better, but now unhappy about the suppressions file:
```
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot initialize module SuppressionFilter - Cannot set property 'file' in module SuppressionFilter to 'resources/checkstyle_suppressions.xml'
```
Probably again due to license headers...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18365812

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Can reproduce the error: https://jclouds.ci.cloudbees.com/job/fix-checkstyle-error/1/console

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18364703

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Looks happy now ;-) https://jclouds.ci.cloudbees.com/job/fix-checkstyle-error/9/

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18382123

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Reopened #15.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Andrew Phillips <no...@github.com>.
Yay! BuildHive now pending, CloudBees PR builder [already running](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/420/)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18353384

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by Everett Toews <no...@github.com>.
Merged and cherry picked into 1.6.x.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18360788

Re: [jclouds] JCLOUDS-78: Fix record pagination problem. Backfill tests. (#15)

Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #42](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/42/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/15#issuecomment-18359270