[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3825: fixed inconsistency of IP on VR when VR is destroyed and recreated (shared network)

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #3825: fixed inconsistency of IP on VR when VR is destroyed and recreated (shared network)
URL: https://github.com/apache/cloudstack/pull/3825#discussion_r369060822
 
 

 ##########
 File path: server/src/main/java/com/cloud/network/NetworkModelImpl.java
 ##########
 @@ -2299,6 +2299,9 @@ public NicVO getPlaceholderNicForRouter(Network network, Long podId) {
                         ipv6 = _ipv6Dao.findByNetworkIdAndIp(network.getId(), nic.getIPv6Address());
                     }
                     //return nic only when its ip address belong to the pod range (for the Basic zone case)
+                    if (vlans.isEmpty()) {
+                        return nic;
+                    }
 
 Review comment:
   I don't think this comment still describves the line below. Can you clarify or remove it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services