You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Erwan de FERRIERES (JIRA)" <ji...@apache.org> on 2009/09/09 15:54:57 UTC
[jira] Created: (OFBIZ-2921) sortable table headers
sortable table headers
----------------------
Key: OFBIZ-2921
URL: https://issues.apache.org/jira/browse/OFBIZ-2921
Project: OFBiz
Issue Type: Improvement
Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: Erwan de FERRIERES
Fix For: SVN trunk
When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2921) sortable table headers
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES updated OFBIZ-2921:
--------------------------------------
Attachment: arrow-gr-dw.png
arrow-gr.png
OFBIZ-2921.diff
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2921) sortable table headers
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES updated OFBIZ-2921:
--------------------------------------
Attachment: OFBIZ-2931.2ndpart.diff
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2931.2ndpart.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2921) sortable table headers
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754178#action_12754178 ]
Adrian Crum commented on OFBIZ-2921:
------------------------------------
My suggestion would be to check out the version before the change. Go to the Find Example screen on your local copy (the one before the change) and on the public demo copy. Compare the two screens. Change themes in the local copy and the demo copy. Compare the two screens. Then go to the Party manager View Profile screen. Compare local copy with demo copy. Change themes, compare again.
The difference should be obvious by then.
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2931.2ndpart.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2921) sortable table headers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-2921:
--------------------------------------
Assignee: Erwan de FERRIERES (was: Jacques Le Roux)
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2931.2ndpart.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-2921) sortable table headers
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754161#action_12754161 ]
Adrian Crum commented on OFBIZ-2921:
------------------------------------
Please do not commit this latest patch and please revert the previous patch. These changes break the UI layout. The header-row-2 style is there for a reason - it should NOT be eliminated.
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2931.2ndpart.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2921) sortable table headers
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754169#action_12754169 ]
Adrian Crum commented on OFBIZ-2921:
------------------------------------
>From the Contributor/Committer Best Practices: "things that already exist must be understood before they are changed."
Understand WHY there are two header styles, THEN you will understand how you are breaking the UI layout.
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2931.2ndpart.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2921) sortable table headers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-2921:
--------------------------------------
Assignee: Jacques Le Roux
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2921) sortable table headers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754186#action_12754186 ]
Jacques Le Roux commented on OFBIZ-2921:
----------------------------------------
It's reverted at revision: 813893
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2931.2ndpart.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-2921) sortable table headers
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES reopened OFBIZ-2921:
---------------------------------------
some header-row-2 were still present and then generated some problems in the interface, like when viewing the content of an entity.
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2931.2ndpart.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2921) sortable table headers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785394#action_12785394 ]
Jacques Le Roux commented on OFBIZ-2921:
----------------------------------------
Bump! Shoud we close ?
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2931.2ndpart.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2921) sortable table headers
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753095#action_12753095 ]
Erwan de FERRIERES commented on OFBIZ-2921:
-------------------------------------------
the modifications for testing have been made in this page : (juste removed the header-row-style for the ListeExamples form)
https://localhost:8443/example/control/FindExample
the images have to be placed in framework/images/webapp/images
It's working on the 3 themes.
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2921) sortable table headers
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES updated OFBIZ-2921:
--------------------------------------
Attachment: arrow-gr-up.png
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2921) sortable table headers
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754168#action_12754168 ]
Erwan de FERRIERES commented on OFBIZ-2921:
-------------------------------------------
could you be more specific and show me some screens that are not well rendered ?
This patch is intended to facilitate the developper work, and to make him add less options when creating a form.
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2931.2ndpart.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2921) sortable table headers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-2921.
----------------------------------
Resolution: Fixed
Thanks Erwan,
Your patch (+ the small trivial changes in other forms) is in trunk at r813307
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2921_sortable_table_headers.patch
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2921) sortable table headers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-2921:
-----------------------------------
Attachment: OFBIZ-2921_sortable_table_headers.patch
OFBIZ-2921_sortable_table_headers would be the patch
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2921) sortable table headers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773042#action_12773042 ]
Jacques Le Roux commented on OFBIZ-2921:
----------------------------------------
Update ?
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2931.2ndpart.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2921) sortable table headers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-2921:
-----------------------------------
Attachment: OFBIZ-2921_sortable_table_headers.patch
Better version of the patch (no space left) but I did not put ExampleForms.xml because I have another change waiting in it.
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2921_sortable_table_headers.patch
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2921) sortable table headers
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753127#action_12753127 ]
Erwan de FERRIERES commented on OFBIZ-2921:
-------------------------------------------
i've just done it on a single forms as PoF. And forgot to tell it in this JIRA's comments. thanks for making it !
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2921) sortable table headers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753117#action_12753117 ]
Jacques Le Roux commented on OFBIZ-2921:
----------------------------------------
Hi Erwan,
This works great and like you I prefer black on white images for these arrows. However before applying, I'd like to have other opinions as if we commit it we have also to remove all header-row-style="header-row-2" (which is not a big deal) to have the other forms working also.
If nobody replies, in some days I will proceed...
Thanks
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2921) sortable table headers
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754172#action_12754172 ]
Erwan de FERRIERES commented on OFBIZ-2921:
-------------------------------------------
the way I understood there was 2 styles is one for the standard tables, the other one for the sortable tables. But I may have been wrong. and I'm going to try to understand this 2 header styles thing
> sortable table headers
> ----------------------
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2921_sortable_table_headers.patch, OFBIZ-2931.2ndpart.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are sortable with the header-row-style="header-row-2" option. with some simple modifications in the css files, we can make the css work for us, and detect if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted of white on grey.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.