[jira] [Commented] (FLINK-15727) Let BashJavaUtils return dynamic configs and JVM parameters in one call

["Xintong Song (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020713#comment-17020713 ] 

Xintong Song commented on FLINK-15727:
--------------------------------------

I'm okay with the proposed change.

The reason we made two separated calls to {{BashJavaUtils}} was that it better decouples the responsibilities and the time cost is acceptable. If the separation complicates logging diagnostic statements, I'm positive to combine the two calls.

> Let BashJavaUtils return dynamic configs and JVM parameters in one call
> -----------------------------------------------------------------------
>
>                 Key: FLINK-15727
>                 URL: https://issues.apache.org/jira/browse/FLINK-15727
>             Project: Flink
>          Issue Type: Improvement
>          Components: Deployment / Scripts
>    Affects Versions: 1.10.0
>            Reporter: Till Rohrmann
>            Priority: Major
>              Labels: usability
>             Fix For: 1.10.0
>
>
> In order to avoid logging diagnostic statements from the {{BashJavaUtils}} util twice as we do it right now, I would suggest to not call the util twice, once for the JVM args and once for the dynamic properties in {{taskmanager.sh}}. Instead I propose that {{BashJavaUtils}} returns both values as the two last lines with different prefixes so that the bash script can easily filter it out.
> cc [~azagrebin] [~xintongsong]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)