[GitHub] storm pull request: STORM-638:UI should show up process-id of the ...

[revans2 <gi...@git.apache.org>]

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/396#discussion_r26242669
  
    --- Diff: storm-core/src/storm.thrift ---
    @@ -205,7 +205,8 @@ struct ExecutorSummary {
       2: required string component_id;
       3: required string host;
       4: required i32 port;
    -  5: required i32 uptime_secs;
    +  5: required i32 process_id;
    --- End diff --
    
    You cannot change a thrift ID like this.  It breaks backwards compatibility too much.  Please make sure that you add new tags instead of changing existing ones.  It is also usually preferable to make the new tag optional, so you can have forward and backwards compatibility.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---