You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/09/13 03:48:10 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
nsivabalan opened a new pull request #3651:
URL: https://github.com/apache/hudi/pull/3651
## What is the purpose of the pull request
- Adding rollback plan and rollback requested instant.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9ae220bf1ba4398068a549211e5215cda7a54f73 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201)
* a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202)
* e8899ba79e726d7f0cbe271b8bfce8aba3a32056 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87a2824f5800148c5ffea303d41b6ea0f4ff78ae Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215)
* 076a9969f6a7401052e998aa816ab9de9072d9b4 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226",
"triggerID" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"triggerType" : "PUSH"
}, {
"hash" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2238",
"triggerID" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"triggerType" : "PUSH"
}, {
"hash" : "9985d101215e2d5bf539b2f3bcac1e9b13982f91",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9985d101215e2d5bf539b2f3bcac1e9b13982f91",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7252e8168b38036ab012f08cdcfac89976bf219e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2238)
* 9985d101215e2d5bf539b2f3bcac1e9b13982f91 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3651:
URL: https://github.com/apache/hudi/pull/3651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c37c9086e407113420841df9e0a49d5813a6d0c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1668a22c0a2fb3feb517a62e952b0d9fda0853a5 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211)
* 67a62e162d8b38102fa19958e9126f77a37ed6a1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213)
* 2687fdc7838ad6ed480ed3e6064f46b656ebb1ef UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aefd1e0e9062f7316ad7c5640d640f86b8493801 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176)
* f74bf781482675e666f05d13cba93539c44fab2d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9ae220bf1ba4398068a549211e5215cda7a54f73 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 270525319f6fe09483704a5a5f8acd90ef78e0b7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194)
* 9ae220bf1ba4398068a549211e5215cda7a54f73 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1668a22c0a2fb3feb517a62e952b0d9fda0853a5 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211)
* 67a62e162d8b38102fa19958e9126f77a37ed6a1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2687fdc7838ad6ed480ed3e6064f46b656ebb1ef Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214)
* 87a2824f5800148c5ffea303d41b6ea0f4ff78ae UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c37c9086e407113420841df9e0a49d5813a6d0c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217)
* 7f511d82c75186c4e84af9aa952beea4b6186e48 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2687fdc7838ad6ed480ed3e6064f46b656ebb1ef Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214)
* 87a2824f5800148c5ffea303d41b6ea0f4ff78ae Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8899ba79e726d7f0cbe271b8bfce8aba3a32056 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210)
* 1668a22c0a2fb3feb517a62e952b0d9fda0853a5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226",
"triggerID" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"triggerType" : "PUSH"
}, {
"hash" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f511d82c75186c4e84af9aa952beea4b6186e48 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226)
* 7252e8168b38036ab012f08cdcfac89976bf219e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226",
"triggerID" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"triggerType" : "PUSH"
}, {
"hash" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2238",
"triggerID" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"triggerType" : "PUSH"
}, {
"hash" : "9985d101215e2d5bf539b2f3bcac1e9b13982f91",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2264",
"triggerID" : "9985d101215e2d5bf539b2f3bcac1e9b13982f91",
"triggerType" : "PUSH"
}, {
"hash" : "de4e738ce07f76e2cd0a5f2adc73e7d9093aed57",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2266",
"triggerID" : "de4e738ce07f76e2cd0a5f2adc73e7d9093aed57",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9985d101215e2d5bf539b2f3bcac1e9b13982f91 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2264)
* de4e738ce07f76e2cd0a5f2adc73e7d9093aed57 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2266)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226",
"triggerID" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"triggerType" : "PUSH"
}, {
"hash" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2238",
"triggerID" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"triggerType" : "PUSH"
}, {
"hash" : "9985d101215e2d5bf539b2f3bcac1e9b13982f91",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2264",
"triggerID" : "9985d101215e2d5bf539b2f3bcac1e9b13982f91",
"triggerType" : "PUSH"
}, {
"hash" : "de4e738ce07f76e2cd0a5f2adc73e7d9093aed57",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "de4e738ce07f76e2cd0a5f2adc73e7d9093aed57",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7252e8168b38036ab012f08cdcfac89976bf219e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2238)
* 9985d101215e2d5bf539b2f3bcac1e9b13982f91 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2264)
* de4e738ce07f76e2cd0a5f2adc73e7d9093aed57 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#discussion_r706989965
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java
##########
@@ -417,6 +425,19 @@ public HoodieActiveTimeline getActiveTimeline() {
*/
public abstract HoodieCleanMetadata clean(HoodieEngineContext context, String cleanInstantTime);
+ /**
+ * Schedule rollback for the instant time.
+ *
+ * @param context HoodieEngineContext
+ * @param instantTime Instant Time for scheduling rollback
+ * @param instantToRollback instant to be rolled back
+ * @return HoodieRollbackPlan containing info on rollback.
+ */
+ public abstract Option<HoodieRollbackPlan> scheduleRollback(HoodieEngineContext context,
Review comment:
Naming this as scheduleRollback to be in line w/ existing clean, compaction etc. But all this method is doing is creation a requested instant and serializing the RollbackPlan. Open to naming this differently
##########
File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/HoodieFlinkCopyOnWriteTable.java
##########
@@ -298,6 +299,12 @@ public void rollbackBootstrap(HoodieEngineContext context, String instantTime) {
return new FlinkScheduleCleanActionExecutor(context, config, this, instantTime, extraMetadata).execute();
}
+ @Override
+ public Option<HoodieRollbackPlan> scheduleRollback(HoodieEngineContext context, String instantTime, HoodieInstant instantToRollback,
+ boolean skipTimelinePublish) {
+ return null;
Review comment:
yet to fix flink and java. will be fixing it in a day or two.
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackHelper.java
##########
@@ -85,22 +113,215 @@ public ListingBasedRollbackHelper(HoodieTableMetaClient metaClient, HoodieWriteC
public List<HoodieRollbackStat> collectRollbackStats(HoodieEngineContext context, HoodieInstant instantToRollback, List<ListingBasedRollbackRequest> rollbackRequests) {
int sparkPartitions = Math.max(Math.min(rollbackRequests.size(), config.getRollbackParallelism()), 1);
context.setJobStatus(this.getClass().getSimpleName(), "Collect rollback stats for upgrade/downgrade");
- JavaPairRDD<String, HoodieRollbackStat> partitionPathRollbackStatsPairRDD = maybeDeleteAndCollectStats(context, instantToRollback, rollbackRequests, sparkPartitions, false);
+ JavaPairRDD<String, HoodieRollbackStat> partitionPathRollbackStatsPairRDD = maybeDeleteAndCollectStatsForUpgrade(context, instantToRollback, rollbackRequests, sparkPartitions, false);
Review comment:
Do we need to fix upgrade as well. As of now, upgrade sends List<ListingBasedRollbackRequest> and rest of the code based uses HoodieListingBasedRollbackRequest.
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/restore/SparkCopyOnWriteRestoreActionExecutor.java
##########
@@ -48,20 +48,23 @@ public SparkCopyOnWriteRestoreActionExecutor(HoodieSparkEngineContext context,
@Override
protected HoodieRollbackMetadata rollbackInstant(HoodieInstant instantToRollback) {
+ if (!instantToRollback.getAction().equals(HoodieTimeline.COMMIT_ACTION)
Review comment:
moved code from below to here.
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java
##########
@@ -53,11 +54,6 @@
private static final Logger LOG = LogManager.getLogger(BaseRollbackActionExecutor.class);
- interface RollbackStrategy extends Serializable {
Review comment:
Note to reviewer: RollbackStrategy is now moved to planActionExecutor and also interface methods have changed.
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackHelper.java
##########
@@ -85,22 +113,215 @@ public ListingBasedRollbackHelper(HoodieTableMetaClient metaClient, HoodieWriteC
public List<HoodieRollbackStat> collectRollbackStats(HoodieEngineContext context, HoodieInstant instantToRollback, List<ListingBasedRollbackRequest> rollbackRequests) {
int sparkPartitions = Math.max(Math.min(rollbackRequests.size(), config.getRollbackParallelism()), 1);
context.setJobStatus(this.getClass().getSimpleName(), "Collect rollback stats for upgrade/downgrade");
- JavaPairRDD<String, HoodieRollbackStat> partitionPathRollbackStatsPairRDD = maybeDeleteAndCollectStats(context, instantToRollback, rollbackRequests, sparkPartitions, false);
+ JavaPairRDD<String, HoodieRollbackStat> partitionPathRollbackStatsPairRDD = maybeDeleteAndCollectStatsForUpgrade(context, instantToRollback, rollbackRequests, sparkPartitions, false);
return partitionPathRollbackStatsPairRDD.map(Tuple2::_2).collect();
}
/**
* May be delete interested files and collect stats or collect stats only.
*
- * @param context instance of {@link HoodieEngineContext} to use.
+ * @param context instance of {@link HoodieEngineContext} to use.
+ * @param instantToRollback {@link HoodieInstant} of interest for which deletion or collect stats is requested.
+ * @param rollbackRequests List of {@link ListingBasedRollbackRequest} to be operated on.
+ * @param sparkPartitions number of spark partitions to use for parallelism.
+ * @return stats collected with or w/o actual deletions.
+ */
+ JavaRDD<HoodieListingBasedRollbackRequest> getListingBasedRollbackRequests(HoodieEngineContext context, HoodieInstant instantToRollback,
+ List<ListingBasedRollbackRequest> rollbackRequests, int sparkPartitions) {
+ JavaSparkContext jsc = HoodieSparkEngineContext.getSparkContext(context);
+ return jsc.parallelize(rollbackRequests, sparkPartitions).map(rollbackRequest -> {
+ switch (rollbackRequest.getType()) {
+ case DELETE_DATA_FILES_ONLY: {
+ final FileStatus[] filesToDeletedStatus = getBaseFilesToBeDeleted(metaClient, config, instantToRollback.getTimestamp(),
+ rollbackRequest.getPartitionPath(), metaClient.getFs());
+ List<String> filesToBeDeleted = Arrays.stream(filesToDeletedStatus).map(fileStatus -> fileStatus.getPath().toString()).collect(Collectors.toList());
+ return new HoodieListingBasedRollbackRequest(rollbackRequest.getPartitionPath(),
+ "", "", filesToBeDeleted, Collections.EMPTY_MAP);
+ }
+ case DELETE_DATA_AND_LOG_FILES: {
+ final FileStatus[] filesToDeletedStatus = getBaseAndLogFilesToBeDeleted(instantToRollback.getTimestamp(), rollbackRequest.getPartitionPath(), metaClient.getFs());
+ List<String> filesToBeDeleted = Arrays.stream(filesToDeletedStatus).map(fileStatus -> fileStatus.getPath().toString()).collect(Collectors.toList());
+ return new HoodieListingBasedRollbackRequest(rollbackRequest.getPartitionPath(), "", "", filesToBeDeleted, Collections.EMPTY_MAP);
+ }
+ case APPEND_ROLLBACK_BLOCK: {
+ String fileId = rollbackRequest.getFileId().get();
+ String latestBaseInstant = rollbackRequest.getLatestBaseInstant().get();
+ // collect all log files that is supposed to be deleted with this rollback
+ Map<FileStatus, Long> writtenLogFileSizeMap = FSUtils.getAllLogFiles(metaClient.getFs(),
+ FSUtils.getPartitionPath(config.getBasePath(), rollbackRequest.getPartitionPath()),
+ fileId, HoodieFileFormat.HOODIE_LOG.getFileExtension(), latestBaseInstant)
+ .collect(Collectors.toMap(HoodieLogFile::getFileStatus, value -> value.getFileStatus().getLen()));
+ Map<String, Long> logFilesToBeDeleted = new HashMap<>();
+ for (Map.Entry<FileStatus, Long> fileToBeDeleted : writtenLogFileSizeMap.entrySet()) {
+ logFilesToBeDeleted.put(fileToBeDeleted.getKey().getPath().toString(), fileToBeDeleted.getValue());
+ }
+ return new HoodieListingBasedRollbackRequest(rollbackRequest.getPartitionPath(), fileId, latestBaseInstant,
+ Collections.EMPTY_LIST, logFilesToBeDeleted);
+ }
+ default:
+ throw new IllegalStateException("Unknown Rollback action " + rollbackRequest);
+ }
+ });
+ }
+
+ /**
+ * May be delete interested files and collect stats or collect stats only.
+ *
+ * @param context instance of {@link HoodieEngineContext} to use.
+ * @param instantToRollback {@link HoodieInstant} of interest for which deletion or collect stats is requested.
+ * @param rollbackRequests List of {@link ListingBasedRollbackRequest} to be operated on.
+ * @param sparkPartitions number of spark partitions to use for parallelism.
+ * @param doDelete {@code true} if deletion has to be done. {@code false} if only stats are to be collected w/o performing any deletes.
+ * @return stats collected with or w/o actual deletions.
+ */
+ private List<Tuple2<String, HoodieRollbackStat>> maybeDeleteAndCollectStatsSequential(HoodieEngineContext context, HoodieInstant instantToRollback,
Review comment:
Due to the issues reported in L 94, doing it sequentically here. once I crack this, will update the patch and will remove the other method.
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackPlanActionExecutor.java
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.table.action.rollback;
+
+import org.apache.hudi.avro.model.HoodieInstantInfo;
+import org.apache.hudi.avro.model.HoodieListingBasedRollbackRequest;
+import org.apache.hudi.avro.model.HoodieRollbackPlan;
+import org.apache.hudi.common.engine.HoodieEngineContext;
+import org.apache.hudi.common.model.HoodieRecordPayload;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.table.timeline.TimelineMetadataUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.exception.HoodieIOException;
+import org.apache.hudi.table.HoodieTable;
+import org.apache.hudi.table.action.BaseActionExecutor;
+import org.apache.hudi.table.marker.MarkerBasedRollbackUtils;
+
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.List;
+
+public abstract class BaseRollbackPlanActionExecutor<T extends HoodieRecordPayload, I, K, O> extends BaseActionExecutor<T, I, K, O, Option<HoodieRollbackPlan>> {
+
+ private static final Logger LOG = LogManager.getLogger(BaseRollbackPlanActionExecutor.class);
+
+ protected final HoodieInstant instantToRollback;
+ private final boolean skipTimelinePublish;
+
+ public static final Integer ROLLBACK_PLAN_VERSION_1 = 1;
+ public static final Integer LATEST_ROLLBACK_PLAN_VERSION = ROLLBACK_PLAN_VERSION_1;
Review comment:
I got inspired from CleanPlanner.
```
public static final Integer CLEAN_PLAN_VERSION_1 = CleanPlanV1MigrationHandler.VERSION;
public static final Integer CLEAN_PLAN_VERSION_2 = CleanPlanV2MigrationHandler.VERSION;
public static final Integer LATEST_CLEAN_PLAN_VERSION = CLEAN_PLAN_VERSION_2;
```
##########
File path: hudi-client/hudi-java-client/src/main/java/org/apache/hudi/table/action/rollback/JavaCopyOnWriteRollbackActionExecutor.java
##########
@@ -54,19 +55,25 @@ public JavaCopyOnWriteRollbackActionExecutor(HoodieEngineContext context,
}
@Override
- protected BaseRollbackActionExecutor.RollbackStrategy getRollbackStrategy() {
+ List<HoodieRollbackStat> rollbackAndGetStats(HoodieInstant instantToRollback, HoodieRollbackPlan rollbackPlan) {
+ return null;
+ }
+
+ /*
+ @Override
Review comment:
yet to fix java
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java
##########
@@ -316,6 +317,13 @@ public HoodieTimeline getCleanTimeline() {
return getActiveTimeline().getCleanerTimeline();
}
+ /**
+ * Get rollback timeline.
+ */
+ public HoodieTimeline getRollbackTimeline() {
Review comment:
yes, we do have for others.
getCompletedCleanTimeline
getCleanTimeline
getCompletedSavepointTimeline
getSavepoints
##########
File path: hudi-common/src/main/avro/HoodieListingBasedRollbackRequest.avsc
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+{
+ "namespace": "org.apache.hudi.avro.model",
+ "type": "record",
+ "name": "HoodieListingBasedRollbackRequest",
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#discussion_r709308528
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackPlanActionExecutor.java
##########
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.table.action.rollback;
+
+import org.apache.hudi.avro.model.HoodieInstantInfo;
+import org.apache.hudi.avro.model.HoodieRollbackPlan;
+import org.apache.hudi.avro.model.HoodieRollbackRequest;
+import org.apache.hudi.common.engine.HoodieEngineContext;
+import org.apache.hudi.common.model.HoodieRecordPayload;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.table.timeline.TimelineMetadataUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.exception.HoodieIOException;
+import org.apache.hudi.table.HoodieTable;
+import org.apache.hudi.table.action.BaseActionExecutor;
+
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.List;
+
+public abstract class BaseRollbackPlanActionExecutor<T extends HoodieRecordPayload, I, K, O> extends BaseActionExecutor<T, I, K, O, Option<HoodieRollbackPlan>> {
+
+ private static final Logger LOG = LogManager.getLogger(BaseRollbackPlanActionExecutor.class);
+
+ protected final HoodieInstant instantToRollback;
+ private final boolean skipTimelinePublish;
+
+ public static final Integer ROLLBACK_PLAN_VERSION_1 = 1;
+ public static final Integer LATEST_ROLLBACK_PLAN_VERSION = ROLLBACK_PLAN_VERSION_1;
+
+ public BaseRollbackPlanActionExecutor(HoodieEngineContext context,
+ HoodieWriteConfig config,
+ HoodieTable<T, I, K, O> table,
+ String instantTime,
+ HoodieInstant instantToRollback,
+ boolean skipTimelinePublish) {
+ super(context, config, table, instantTime);
+ this.instantToRollback = instantToRollback;
+ this.skipTimelinePublish = skipTimelinePublish;
+ }
+
+ /**
+ * Interface for RollbackStrategy. There are two types supported, listing based and marker based.
+ */
+ interface RollbackStrategy extends Serializable {
+
+ /**
+ * Fetch list of {@link HoodieRollbackRequest}s to be added to rollback plan.
+ * @param instantToRollback instant to be rolled back.
+ * @return list of {@link HoodieRollbackRequest}s to be added to rollback plan
+ */
+ List<HoodieRollbackRequest> getRollbackRequest(HoodieInstant instantToRollback);
+
+ }
+
+ /**
+ * Fetch the Rollback strategy used.
+ *
+ * @return
+ */
+ protected abstract RollbackStrategy getRollbackStrategy();
+
+ /**
+ * Creates a Rollback plan if there are files to be rolledback and stores them in instant file.
+ * Rollback Plan contains absolute file paths.
+ *
+ * @param startRollbackTime Rollback Instant Time
+ * @return Rollback Plan if generated
+ */
+ protected Option<HoodieRollbackPlan> requestRollback(String startRollbackTime) {
+ final HoodieInstant rollbackInstant = new HoodieInstant(HoodieInstant.State.REQUESTED, HoodieTimeline.ROLLBACK_ACTION, startRollbackTime);
+ try {
+ List<HoodieRollbackRequest> rollbackRequests = new ArrayList<>();
+ if (!instantToRollback.isRequested()) {
+ rollbackRequests.addAll(getRollbackStrategy().getRollbackRequest(instantToRollback));
+ }
+ HoodieRollbackPlan rollbackPlan = new HoodieRollbackPlan(new HoodieInstantInfo(instantToRollback.getTimestamp(),
+ instantToRollback.getAction()), rollbackRequests, LATEST_ROLLBACK_PLAN_VERSION);
+ if (!skipTimelinePublish) {
+ if (table.getRollbackTimeline().filterInflightsAndRequested().containsInstant(rollbackInstant.getTimestamp())) {
+ LOG.warn("Request Rollback found with instant time " + rollbackInstant + ", hence skipping scheduling rollback");
+ } else {
+ table.getActiveTimeline().saveToRollbackRequested(rollbackInstant, TimelineMetadataUtils.serializeRollbackPlan(rollbackPlan));
+ table.getMetaClient().reloadActiveTimeline();
+ LOG.info("Requesting Rollback with instant time " + rollbackInstant);
+ }
+ }
+ return Option.of(rollbackPlan);
+ } catch (IOException e) {
Review comment:
just trying to keep in sync with other operations like clean, compaction etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2687fdc7838ad6ed480ed3e6064f46b656ebb1ef Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214)
* 87a2824f5800148c5ffea303d41b6ea0f4ff78ae Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215)
* 076a9969f6a7401052e998aa816ab9de9072d9b4 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aefd1e0e9062f7316ad7c5640d640f86b8493801 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#discussion_r707352260
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -590,6 +591,11 @@ public boolean rollback(final String commitInstantTime) throws HoodieRollbackExc
.filter(instant -> HoodieActiveTimeline.EQUALS.test(instant.getTimestamp(), commitInstantTime))
.findFirst());
if (commitInstantOpt.isPresent()) {
+
+ LOG.info("Scheduling Rollback at instant time :" + rollbackInstantTime);
+ Option<HoodieRollbackPlan> rollbackPlan = createTable(config, hadoopConf)
Review comment:
if this follows convention of how we do compaction scheduling, i think its good.
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java
##########
@@ -316,6 +317,13 @@ public HoodieTimeline getCleanTimeline() {
return getActiveTimeline().getCleanerTimeline();
}
+ /**
+ * Get rollback timeline.
+ */
+ public HoodieTimeline getRollbackTimeline() {
Review comment:
we should avoid these sort of helpers unless one exists for each of the other actions. if not, lets remove
##########
File path: hudi-common/src/main/avro/HoodieListingBasedRollbackRequest.avsc
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+{
+ "namespace": "org.apache.hudi.avro.model",
+ "type": "record",
+ "name": "HoodieListingBasedRollbackRequest",
Review comment:
Could be just store generically what file paths need to be deleted and where command blocks need to be logged? then the plan becomes the source of truth
##########
File path: hudi-common/src/main/avro/HoodieListingBasedRollbackRequest.avsc
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+{
+ "namespace": "org.apache.hudi.avro.model",
+ "type": "record",
+ "name": "HoodieListingBasedRollbackRequest",
Review comment:
why does the plan care about listing vs marker based for the plan serialization itself?
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackPlanActionExecutor.java
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.table.action.rollback;
+
+import org.apache.hudi.avro.model.HoodieInstantInfo;
+import org.apache.hudi.avro.model.HoodieListingBasedRollbackRequest;
+import org.apache.hudi.avro.model.HoodieRollbackPlan;
+import org.apache.hudi.common.engine.HoodieEngineContext;
+import org.apache.hudi.common.model.HoodieRecordPayload;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.table.timeline.TimelineMetadataUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.exception.HoodieIOException;
+import org.apache.hudi.table.HoodieTable;
+import org.apache.hudi.table.action.BaseActionExecutor;
+import org.apache.hudi.table.marker.MarkerBasedRollbackUtils;
+
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.List;
+
+public abstract class BaseRollbackPlanActionExecutor<T extends HoodieRecordPayload, I, K, O> extends BaseActionExecutor<T, I, K, O, Option<HoodieRollbackPlan>> {
+
+ private static final Logger LOG = LogManager.getLogger(BaseRollbackPlanActionExecutor.class);
+
+ protected final HoodieInstant instantToRollback;
+ private final boolean skipTimelinePublish;
+
+ public static final Integer ROLLBACK_PLAN_VERSION_1 = 1;
+ public static final Integer LATEST_ROLLBACK_PLAN_VERSION = ROLLBACK_PLAN_VERSION_1;
Review comment:
rename `CURRENT_ROLLBACK_PLAN_VERSION` to be consistent with other places
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackPlanActionExecutor.java
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.table.action.rollback;
+
+import org.apache.hudi.avro.model.HoodieInstantInfo;
+import org.apache.hudi.avro.model.HoodieListingBasedRollbackRequest;
+import org.apache.hudi.avro.model.HoodieRollbackPlan;
+import org.apache.hudi.common.engine.HoodieEngineContext;
+import org.apache.hudi.common.model.HoodieRecordPayload;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.table.timeline.TimelineMetadataUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.exception.HoodieIOException;
+import org.apache.hudi.table.HoodieTable;
+import org.apache.hudi.table.action.BaseActionExecutor;
+import org.apache.hudi.table.marker.MarkerBasedRollbackUtils;
+
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.List;
+
+public abstract class BaseRollbackPlanActionExecutor<T extends HoodieRecordPayload, I, K, O> extends BaseActionExecutor<T, I, K, O, Option<HoodieRollbackPlan>> {
+
+ private static final Logger LOG = LogManager.getLogger(BaseRollbackPlanActionExecutor.class);
+
+ protected final HoodieInstant instantToRollback;
+ private final boolean skipTimelinePublish;
+
+ public static final Integer ROLLBACK_PLAN_VERSION_1 = 1;
+ public static final Integer LATEST_ROLLBACK_PLAN_VERSION = ROLLBACK_PLAN_VERSION_1;
Review comment:
whats your specific question? handling rollbacks with and without a plan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#discussion_r709190362
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseMarkerBasedRollbackStrategy.java
##########
@@ -18,59 +18,60 @@
package org.apache.hudi.table.action.rollback;
-import org.apache.hudi.client.WriteStatus;
-import org.apache.hudi.common.HoodieRollbackStat;
+import org.apache.hudi.avro.model.HoodieRollbackRequest;
import org.apache.hudi.common.engine.HoodieEngineContext;
-import org.apache.hudi.common.model.HoodieKey;
-import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.fs.FSUtils;
import org.apache.hudi.common.model.HoodieRecordPayload;
import org.apache.hudi.common.model.IOType;
import org.apache.hudi.common.table.timeline.HoodieInstant;
-import org.apache.hudi.common.util.collection.Pair;
import org.apache.hudi.config.HoodieWriteConfig;
import org.apache.hudi.exception.HoodieRollbackException;
import org.apache.hudi.table.HoodieTable;
import org.apache.hudi.table.marker.MarkerBasedRollbackUtils;
import org.apache.hudi.table.marker.WriteMarkers;
+import org.apache.hadoop.fs.Path;
+
+import java.util.ArrayList;
+import java.util.Collections;
import java.util.List;
-import java.util.stream.Collectors;
-@SuppressWarnings("checkstyle:LineLength")
-public class JavaMarkerBasedRollbackStrategy<T extends HoodieRecordPayload> extends AbstractMarkerBasedRollbackStrategy<T, List<HoodieRecord<T>>, List<HoodieKey>, List<WriteStatus>> {
- public JavaMarkerBasedRollbackStrategy(HoodieTable<T, List<HoodieRecord<T>>, List<HoodieKey>, List<WriteStatus>> table,
- HoodieEngineContext context,
- HoodieWriteConfig config,
- String instantTime) {
+import static org.apache.hudi.table.action.rollback.BaseRollbackHelper.EMPTY_STRING;
+
+public class BaseMarkerBasedRollbackStrategy<T extends HoodieRecordPayload, I, K, O> extends AbstractMarkerBasedRollbackStrategy {
+
+ public BaseMarkerBasedRollbackStrategy(HoodieTable<T, I, K, O> table, HoodieEngineContext context, HoodieWriteConfig config, String instantTime) {
super(table, context, config, instantTime);
}
@Override
- public List<HoodieRollbackStat> execute(HoodieInstant instantToRollback) {
+ public List<HoodieRollbackRequest> getRollbackRequest(HoodieInstant instantToRollback) {
try {
List<String> markerPaths = MarkerBasedRollbackUtils.getAllMarkerPaths(
table, context, instantToRollback.getTimestamp(), config.getRollbackParallelism());
- List<HoodieRollbackStat> rollbackStats = context.map(markerPaths, markerFilePath -> {
+ List<HoodieRollbackRequest> rollbackRequests = new ArrayList<>();
+ int parallelism = Math.max(Math.min(markerPaths.size(), config.getRollbackParallelism()), 1);
+ context.foreach(markerPaths, markerFilePath -> {
String typeStr = markerFilePath.substring(markerFilePath.lastIndexOf(".") + 1);
IOType type = IOType.valueOf(typeStr);
switch (type) {
case MERGE:
- return undoMerge(WriteMarkers.stripMarkerSuffix(markerFilePath));
- case APPEND:
- return undoAppend(WriteMarkers.stripMarkerSuffix(markerFilePath), instantToRollback);
case CREATE:
- return undoCreate(WriteMarkers.stripMarkerSuffix(markerFilePath));
+ String fileToDelete = WriteMarkers.stripMarkerSuffix(markerFilePath);
+ Path fullDeletePath = new Path(basePath, fileToDelete);
+ String partitionPath = FSUtils.getRelativePartitionPath(new Path(basePath), fullDeletePath.getParent());
Review comment:
https://issues.apache.org/jira/browse/HUDI-2437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f74bf781482675e666f05d13cba93539c44fab2d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179)
* 270525319f6fe09483704a5a5f8acd90ef78e0b7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87a2824f5800148c5ffea303d41b6ea0f4ff78ae Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215)
* 076a9969f6a7401052e998aa816ab9de9072d9b4 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 270525319f6fe09483704a5a5f8acd90ef78e0b7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194)
* 9ae220bf1ba4398068a549211e5215cda7a54f73 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1668a22c0a2fb3feb517a62e952b0d9fda0853a5 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211)
* 67a62e162d8b38102fa19958e9126f77a37ed6a1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67a62e162d8b38102fa19958e9126f77a37ed6a1 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213)
* 2687fdc7838ad6ed480ed3e6064f46b656ebb1ef Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226",
"triggerID" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"triggerType" : "PUSH"
}, {
"hash" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2238",
"triggerID" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f511d82c75186c4e84af9aa952beea4b6186e48 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226)
* 7252e8168b38036ab012f08cdcfac89976bf219e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2238)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 076a9969f6a7401052e998aa816ab9de9072d9b4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216)
* 1c37c9086e407113420841df9e0a49d5813a6d0c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f74bf781482675e666f05d13cba93539c44fab2d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226",
"triggerID" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"triggerType" : "PUSH"
}, {
"hash" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2238",
"triggerID" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"triggerType" : "PUSH"
}, {
"hash" : "9985d101215e2d5bf539b2f3bcac1e9b13982f91",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2264",
"triggerID" : "9985d101215e2d5bf539b2f3bcac1e9b13982f91",
"triggerType" : "PUSH"
}, {
"hash" : "de4e738ce07f76e2cd0a5f2adc73e7d9093aed57",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2266",
"triggerID" : "de4e738ce07f76e2cd0a5f2adc73e7d9093aed57",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* de4e738ce07f76e2cd0a5f2adc73e7d9093aed57 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2266)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226",
"triggerID" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"triggerType" : "PUSH"
}, {
"hash" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2238",
"triggerID" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7252e8168b38036ab012f08cdcfac89976bf219e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2238)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#discussion_r706988972
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackPlanActionExecutor.java
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.table.action.rollback;
+
+import org.apache.hudi.avro.model.HoodieInstantInfo;
+import org.apache.hudi.avro.model.HoodieListingBasedRollbackRequest;
+import org.apache.hudi.avro.model.HoodieRollbackPlan;
+import org.apache.hudi.common.engine.HoodieEngineContext;
+import org.apache.hudi.common.model.HoodieRecordPayload;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.table.timeline.TimelineMetadataUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.exception.HoodieIOException;
+import org.apache.hudi.table.HoodieTable;
+import org.apache.hudi.table.action.BaseActionExecutor;
+import org.apache.hudi.table.marker.MarkerBasedRollbackUtils;
+
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.List;
+
+public abstract class BaseRollbackPlanActionExecutor<T extends HoodieRecordPayload, I, K, O> extends BaseActionExecutor<T, I, K, O, Option<HoodieRollbackPlan>> {
+
+ private static final Logger LOG = LogManager.getLogger(BaseRollbackPlanActionExecutor.class);
+
+ protected final HoodieInstant instantToRollback;
+ private final boolean skipTimelinePublish;
+
+ public static final Integer ROLLBACK_PLAN_VERSION_1 = 1;
+ public static final Integer LATEST_ROLLBACK_PLAN_VERSION = ROLLBACK_PLAN_VERSION_1;
Review comment:
Haven't added any migration steps yet since this is first version. Please advise me on how to go about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8899ba79e726d7f0cbe271b8bfce8aba3a32056 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210)
* 1668a22c0a2fb3feb517a62e952b0d9fda0853a5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211)
* 67a62e162d8b38102fa19958e9126f77a37ed6a1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#discussion_r709109702
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackPlanActionExecutor.java
##########
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.table.action.rollback;
+
+import org.apache.hudi.avro.model.HoodieInstantInfo;
+import org.apache.hudi.avro.model.HoodieRollbackPlan;
+import org.apache.hudi.avro.model.HoodieRollbackRequest;
+import org.apache.hudi.common.engine.HoodieEngineContext;
+import org.apache.hudi.common.model.HoodieRecordPayload;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.table.timeline.TimelineMetadataUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.exception.HoodieIOException;
+import org.apache.hudi.table.HoodieTable;
+import org.apache.hudi.table.action.BaseActionExecutor;
+
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.List;
+
+public abstract class BaseRollbackPlanActionExecutor<T extends HoodieRecordPayload, I, K, O> extends BaseActionExecutor<T, I, K, O, Option<HoodieRollbackPlan>> {
+
+ private static final Logger LOG = LogManager.getLogger(BaseRollbackPlanActionExecutor.class);
+
+ protected final HoodieInstant instantToRollback;
+ private final boolean skipTimelinePublish;
+
+ public static final Integer ROLLBACK_PLAN_VERSION_1 = 1;
+ public static final Integer LATEST_ROLLBACK_PLAN_VERSION = ROLLBACK_PLAN_VERSION_1;
+
+ public BaseRollbackPlanActionExecutor(HoodieEngineContext context,
+ HoodieWriteConfig config,
+ HoodieTable<T, I, K, O> table,
+ String instantTime,
+ HoodieInstant instantToRollback,
+ boolean skipTimelinePublish) {
+ super(context, config, table, instantTime);
+ this.instantToRollback = instantToRollback;
+ this.skipTimelinePublish = skipTimelinePublish;
+ }
+
+ /**
+ * Interface for RollbackStrategy. There are two types supported, listing based and marker based.
+ */
+ interface RollbackStrategy extends Serializable {
+
+ /**
+ * Fetch list of {@link HoodieRollbackRequest}s to be added to rollback plan.
+ * @param instantToRollback instant to be rolled back.
+ * @return list of {@link HoodieRollbackRequest}s to be added to rollback plan
+ */
+ List<HoodieRollbackRequest> getRollbackRequest(HoodieInstant instantToRollback);
+
+ }
+
+ /**
+ * Fetch the Rollback strategy used.
+ *
+ * @return
+ */
+ protected abstract RollbackStrategy getRollbackStrategy();
+
+ /**
+ * Creates a Rollback plan if there are files to be rolledback and stores them in instant file.
+ * Rollback Plan contains absolute file paths.
+ *
+ * @param startRollbackTime Rollback Instant Time
+ * @return Rollback Plan if generated
+ */
+ protected Option<HoodieRollbackPlan> requestRollback(String startRollbackTime) {
+ final HoodieInstant rollbackInstant = new HoodieInstant(HoodieInstant.State.REQUESTED, HoodieTimeline.ROLLBACK_ACTION, startRollbackTime);
+ try {
+ List<HoodieRollbackRequest> rollbackRequests = new ArrayList<>();
+ if (!instantToRollback.isRequested()) {
+ rollbackRequests.addAll(getRollbackStrategy().getRollbackRequest(instantToRollback));
+ }
+ HoodieRollbackPlan rollbackPlan = new HoodieRollbackPlan(new HoodieInstantInfo(instantToRollback.getTimestamp(),
+ instantToRollback.getAction()), rollbackRequests, LATEST_ROLLBACK_PLAN_VERSION);
+ if (!skipTimelinePublish) {
+ if (table.getRollbackTimeline().filterInflightsAndRequested().containsInstant(rollbackInstant.getTimestamp())) {
+ LOG.warn("Request Rollback found with instant time " + rollbackInstant + ", hence skipping scheduling rollback");
+ } else {
+ table.getActiveTimeline().saveToRollbackRequested(rollbackInstant, TimelineMetadataUtils.serializeRollbackPlan(rollbackPlan));
+ table.getMetaClient().reloadActiveTimeline();
+ LOG.info("Requesting Rollback with instant time " + rollbackInstant);
+ }
+ }
+ return Option.of(rollbackPlan);
+ } catch (IOException e) {
Review comment:
The `Option` is never empty, there is no need to return Option here, just return `rollbackPlan` which is more straight-forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aefd1e0e9062f7316ad7c5640d640f86b8493801 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176)
* f74bf781482675e666f05d13cba93539c44fab2d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f74bf781482675e666f05d13cba93539c44fab2d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179)
* 270525319f6fe09483704a5a5f8acd90ef78e0b7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202)
* e8899ba79e726d7f0cbe271b8bfce8aba3a32056 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210)
* 1668a22c0a2fb3feb517a62e952b0d9fda0853a5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 076a9969f6a7401052e998aa816ab9de9072d9b4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216)
* 1c37c9086e407113420841df9e0a49d5813a6d0c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226",
"triggerID" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f511d82c75186c4e84af9aa952beea4b6186e48 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#discussion_r709251029
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/AbstractMarkerBasedRollbackStrategy.java
##########
@@ -65,83 +63,32 @@ public AbstractMarkerBasedRollbackStrategy(HoodieTable<T, I, K, O> table, Hoodie
this.instantTime = instantTime;
}
- protected HoodieRollbackStat undoMerge(String mergedBaseFilePath) throws IOException {
- LOG.info("Rolling back by deleting the merged base file:" + mergedBaseFilePath);
- return deleteBaseFile(mergedBaseFilePath);
- }
-
- protected HoodieRollbackStat undoCreate(String createdBaseFilePath) throws IOException {
- LOG.info("Rolling back by deleting the created base file:" + createdBaseFilePath);
- return deleteBaseFile(createdBaseFilePath);
- }
-
- private HoodieRollbackStat deleteBaseFile(String baseFilePath) throws IOException {
- Path fullDeletePath = new Path(basePath, baseFilePath);
- String partitionPath = FSUtils.getRelativePartitionPath(new Path(basePath), fullDeletePath.getParent());
- boolean isDeleted = table.getMetaClient().getFs().delete(fullDeletePath);
- return HoodieRollbackStat.newBuilder()
- .withPartitionPath(partitionPath)
- .withDeletedFileResult(baseFilePath, isDeleted)
- .build();
- }
-
- protected HoodieRollbackStat undoAppend(String appendBaseFilePath, HoodieInstant instantToRollback) throws IOException, InterruptedException {
+ protected HoodieRollbackRequest getRollbackRequestForAppend(String appendBaseFilePath) throws IOException {
Path baseFilePathForAppend = new Path(basePath, appendBaseFilePath);
String fileId = FSUtils.getFileIdFromFilePath(baseFilePathForAppend);
String baseCommitTime = FSUtils.getCommitTime(baseFilePathForAppend.getName());
String partitionPath = FSUtils.getRelativePartitionPath(new Path(basePath), new Path(basePath, appendBaseFilePath).getParent());
- final Map<FileStatus, Long> writtenLogFileSizeMap = getWrittenLogFileSizeMap(partitionPath, baseCommitTime, fileId);
-
- HoodieLogFormat.Writer writer = null;
- try {
- Path partitionFullPath = FSUtils.getPartitionPath(basePath, partitionPath);
-
- if (!table.getMetaClient().getFs().exists(partitionFullPath)) {
- return HoodieRollbackStat.newBuilder()
- .withPartitionPath(partitionPath)
- .build();
- }
- writer = HoodieLogFormat.newWriterBuilder()
- .onParentPath(partitionFullPath)
- .withFileId(fileId)
- .overBaseCommit(baseCommitTime)
- .withFs(table.getMetaClient().getFs())
- .withFileExtension(HoodieLogFile.DELTA_EXTENSION).build();
-
- // generate metadata
- Map<HoodieLogBlock.HeaderMetadataType, String> header = RollbackUtils.generateHeader(instantToRollback.getTimestamp(), instantTime);
- // if update belongs to an existing log file
- writer.appendBlock(new HoodieCommandBlock(header));
- } finally {
- try {
- if (writer != null) {
- writer.close();
- }
- } catch (IOException io) {
- throw new HoodieIOException("Error closing append of rollback block..", io);
- }
+ Map<FileStatus, Long> writtenLogFileSizeMap = getWrittenLogFileSizeMap(partitionPath, baseCommitTime, fileId);
+ Map<String, Long> writtenLogFileStrSizeMap = new HashMap<>();
+ for (Map.Entry<FileStatus, Long> entry : writtenLogFileSizeMap.entrySet()) {
+ writtenLogFileStrSizeMap.put(entry.getKey().getPath().toString(), entry.getValue());
}
-
- // the information of files appended to is required for metadata sync
- Map<FileStatus, Long> filesToNumBlocksRollback = Collections.singletonMap(
- table.getMetaClient().getFs().getFileStatus(Objects.requireNonNull(writer).getLogFile().getPath()),
- 1L);
-
- return HoodieRollbackStat.newBuilder()
- .withPartitionPath(partitionPath)
- .withRollbackBlockAppendResults(filesToNumBlocksRollback)
- .withWrittenLogFileSizeMap(writtenLogFileSizeMap).build();
+ return new HoodieRollbackRequest(partitionPath, fileId, baseCommitTime, Collections.emptyList(), writtenLogFileStrSizeMap);
}
/**
* Returns written log file size map for the respective baseCommitTime to assist in metadata table syncing.
- * @param partitionPath partition path of interest
+ *
+ * @param partitionPath partition path of interest
* @param baseCommitTime base commit time of interest
- * @param fileId fileId of interest
+ * @param fileId fileId of interest
* @return Map<FileStatus, File size>
* @throws IOException
*/
protected Map<FileStatus, Long> getWrittenLogFileSizeMap(String partitionPath, String baseCommitTime, String fileId) throws IOException {
- return Collections.EMPTY_MAP;
+ // collect all log files that is supposed to be deleted with this rollback
+ return FSUtils.getAllLogFiles(table.getMetaClient().getFs(),
Review comment:
I don't fully get this point. I have created a follow up ticket [here](https://issues.apache.org/jira/browse/HUDI-2436). will follow up with you.
here is my understanding: of a scenario using cloud stores that does not support append.
If there was crash during a commit, when listing log files to be logged, the last one which got crashed may not be part of the rollback plan. but thats should be fine. anyways, its not available via listing. and so I assume even during compaction those will not be available. we will proceed on with rollback by adding another log block (file). and this will get replayed to metadata table.
If you are talking about the case, where a crash happens when rollback itself is being logged and crashed just before committing to metadata table.
we should be ok here too. we will retry the rollback which will redo the action phase. and will add new log blocks (with same old logs that were part of failed writes, just that it may not be able to successfully delete). and this will get applied to metadata table. We just have to ensure when applying changes to metadata table, we consider all files from the plan and not just the ones that got successfully deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2687fdc7838ad6ed480ed3e6064f46b656ebb1ef Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8899ba79e726d7f0cbe271b8bfce8aba3a32056 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210)
* 1668a22c0a2fb3feb517a62e952b0d9fda0853a5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aefd1e0e9062f7316ad7c5640d640f86b8493801 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176)
* f74bf781482675e666f05d13cba93539c44fab2d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226",
"triggerID" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c37c9086e407113420841df9e0a49d5813a6d0c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217)
* 7f511d82c75186c4e84af9aa952beea4b6186e48 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aefd1e0e9062f7316ad7c5640d640f86b8493801 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 270525319f6fe09483704a5a5f8acd90ef78e0b7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#discussion_r708817513
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -590,6 +590,10 @@ public boolean rollback(final String commitInstantTime) throws HoodieRollbackExc
.filter(instant -> HoodieActiveTimeline.EQUALS.test(instant.getTimestamp(), commitInstantTime))
.findFirst());
if (commitInstantOpt.isPresent()) {
+ LOG.info("Scheduling Rollback at instant time :" + rollbackInstantTime);
+ createTable(config, hadoopConf)
Review comment:
do something with the return value?
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseMarkerBasedRollbackStrategy.java
##########
@@ -18,59 +18,60 @@
package org.apache.hudi.table.action.rollback;
-import org.apache.hudi.client.WriteStatus;
-import org.apache.hudi.common.HoodieRollbackStat;
+import org.apache.hudi.avro.model.HoodieRollbackRequest;
import org.apache.hudi.common.engine.HoodieEngineContext;
-import org.apache.hudi.common.model.HoodieKey;
-import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.fs.FSUtils;
import org.apache.hudi.common.model.HoodieRecordPayload;
import org.apache.hudi.common.model.IOType;
import org.apache.hudi.common.table.timeline.HoodieInstant;
-import org.apache.hudi.common.util.collection.Pair;
import org.apache.hudi.config.HoodieWriteConfig;
import org.apache.hudi.exception.HoodieRollbackException;
import org.apache.hudi.table.HoodieTable;
import org.apache.hudi.table.marker.MarkerBasedRollbackUtils;
import org.apache.hudi.table.marker.WriteMarkers;
+import org.apache.hadoop.fs.Path;
+
+import java.util.ArrayList;
+import java.util.Collections;
import java.util.List;
-import java.util.stream.Collectors;
-@SuppressWarnings("checkstyle:LineLength")
-public class JavaMarkerBasedRollbackStrategy<T extends HoodieRecordPayload> extends AbstractMarkerBasedRollbackStrategy<T, List<HoodieRecord<T>>, List<HoodieKey>, List<WriteStatus>> {
- public JavaMarkerBasedRollbackStrategy(HoodieTable<T, List<HoodieRecord<T>>, List<HoodieKey>, List<WriteStatus>> table,
- HoodieEngineContext context,
- HoodieWriteConfig config,
- String instantTime) {
+import static org.apache.hudi.table.action.rollback.BaseRollbackHelper.EMPTY_STRING;
+
+public class BaseMarkerBasedRollbackStrategy<T extends HoodieRecordPayload, I, K, O> extends AbstractMarkerBasedRollbackStrategy {
+
+ public BaseMarkerBasedRollbackStrategy(HoodieTable<T, I, K, O> table, HoodieEngineContext context, HoodieWriteConfig config, String instantTime) {
super(table, context, config, instantTime);
}
@Override
- public List<HoodieRollbackStat> execute(HoodieInstant instantToRollback) {
+ public List<HoodieRollbackRequest> getRollbackRequest(HoodieInstant instantToRollback) {
try {
List<String> markerPaths = MarkerBasedRollbackUtils.getAllMarkerPaths(
table, context, instantToRollback.getTimestamp(), config.getRollbackParallelism());
- List<HoodieRollbackStat> rollbackStats = context.map(markerPaths, markerFilePath -> {
+ List<HoodieRollbackRequest> rollbackRequests = new ArrayList<>();
+ int parallelism = Math.max(Math.min(markerPaths.size(), config.getRollbackParallelism()), 1);
+ context.foreach(markerPaths, markerFilePath -> {
String typeStr = markerFilePath.substring(markerFilePath.lastIndexOf(".") + 1);
IOType type = IOType.valueOf(typeStr);
switch (type) {
case MERGE:
- return undoMerge(WriteMarkers.stripMarkerSuffix(markerFilePath));
- case APPEND:
- return undoAppend(WriteMarkers.stripMarkerSuffix(markerFilePath), instantToRollback);
case CREATE:
- return undoCreate(WriteMarkers.stripMarkerSuffix(markerFilePath));
+ String fileToDelete = WriteMarkers.stripMarkerSuffix(markerFilePath);
+ Path fullDeletePath = new Path(basePath, fileToDelete);
+ String partitionPath = FSUtils.getRelativePartitionPath(new Path(basePath), fullDeletePath.getParent());
Review comment:
We should move any helper that is not actually doing anything with an fs instance to somethihg like PathUtils
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/HoodieRollbackRequestInternal.java
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.table.action.rollback;
+
+import org.apache.hudi.avro.model.HoodieRollbackRequest;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+public class HoodieRollbackRequestInternal {
Review comment:
SerializableRollbackRequest
##########
File path: hudi-common/src/main/avro/HoodieRollbackPlan.avsc
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+{
+ "namespace": "org.apache.hudi.avro.model",
+ "type": "record",
+ "name": "HoodieRollbackPlan",
+ "fields": [
+ {
+ "name": "instantToRollback",
+ "doc": "Hoodie instant that needs to be rolled back",
+ "default": null,
+ "type": "HoodieInstantInfo"
+ },
+ {
+ "name": "RollbackRequests",
+ "type":["null", {
+ "type":"array",
+ "items":{
+ "type": "record",
+ "name": "HoodieRollbackRequest",
+ "fields": [
+ {"name": "partitionPath", "type": "string"},
+ {"name": "fileId",
+ "type":["null", "string"],
+ "default": null
+ },
+ {"name": "latestBaseInstant",
+ "type":["null", "string"],
+ "default": null
+ },
+ {"name": "filesToBeDeleted",
+ "default": [],
+ "type": {
+ "type": "array",
+ "default": [],
+ "items": "string"
+ }
+ },
+ {"name": "logFilesToBeDeleted",
Review comment:
rename this? log blocks to rollback? or sth?
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/AbstractMarkerBasedRollbackStrategy.java
##########
@@ -65,83 +63,32 @@ public AbstractMarkerBasedRollbackStrategy(HoodieTable<T, I, K, O> table, Hoodie
this.instantTime = instantTime;
}
- protected HoodieRollbackStat undoMerge(String mergedBaseFilePath) throws IOException {
- LOG.info("Rolling back by deleting the merged base file:" + mergedBaseFilePath);
- return deleteBaseFile(mergedBaseFilePath);
- }
-
- protected HoodieRollbackStat undoCreate(String createdBaseFilePath) throws IOException {
- LOG.info("Rolling back by deleting the created base file:" + createdBaseFilePath);
- return deleteBaseFile(createdBaseFilePath);
- }
-
- private HoodieRollbackStat deleteBaseFile(String baseFilePath) throws IOException {
- Path fullDeletePath = new Path(basePath, baseFilePath);
- String partitionPath = FSUtils.getRelativePartitionPath(new Path(basePath), fullDeletePath.getParent());
- boolean isDeleted = table.getMetaClient().getFs().delete(fullDeletePath);
- return HoodieRollbackStat.newBuilder()
- .withPartitionPath(partitionPath)
- .withDeletedFileResult(baseFilePath, isDeleted)
- .build();
- }
-
- protected HoodieRollbackStat undoAppend(String appendBaseFilePath, HoodieInstant instantToRollback) throws IOException, InterruptedException {
+ protected HoodieRollbackRequest getRollbackRequestForAppend(String appendBaseFilePath) throws IOException {
Path baseFilePathForAppend = new Path(basePath, appendBaseFilePath);
String fileId = FSUtils.getFileIdFromFilePath(baseFilePathForAppend);
String baseCommitTime = FSUtils.getCommitTime(baseFilePathForAppend.getName());
String partitionPath = FSUtils.getRelativePartitionPath(new Path(basePath), new Path(basePath, appendBaseFilePath).getParent());
- final Map<FileStatus, Long> writtenLogFileSizeMap = getWrittenLogFileSizeMap(partitionPath, baseCommitTime, fileId);
-
- HoodieLogFormat.Writer writer = null;
- try {
- Path partitionFullPath = FSUtils.getPartitionPath(basePath, partitionPath);
-
- if (!table.getMetaClient().getFs().exists(partitionFullPath)) {
- return HoodieRollbackStat.newBuilder()
- .withPartitionPath(partitionPath)
- .build();
- }
- writer = HoodieLogFormat.newWriterBuilder()
- .onParentPath(partitionFullPath)
- .withFileId(fileId)
- .overBaseCommit(baseCommitTime)
- .withFs(table.getMetaClient().getFs())
- .withFileExtension(HoodieLogFile.DELTA_EXTENSION).build();
-
- // generate metadata
- Map<HoodieLogBlock.HeaderMetadataType, String> header = RollbackUtils.generateHeader(instantToRollback.getTimestamp(), instantTime);
- // if update belongs to an existing log file
- writer.appendBlock(new HoodieCommandBlock(header));
- } finally {
- try {
- if (writer != null) {
- writer.close();
- }
- } catch (IOException io) {
- throw new HoodieIOException("Error closing append of rollback block..", io);
- }
+ Map<FileStatus, Long> writtenLogFileSizeMap = getWrittenLogFileSizeMap(partitionPath, baseCommitTime, fileId);
+ Map<String, Long> writtenLogFileStrSizeMap = new HashMap<>();
+ for (Map.Entry<FileStatus, Long> entry : writtenLogFileSizeMap.entrySet()) {
+ writtenLogFileStrSizeMap.put(entry.getKey().getPath().toString(), entry.getValue());
}
-
- // the information of files appended to is required for metadata sync
- Map<FileStatus, Long> filesToNumBlocksRollback = Collections.singletonMap(
- table.getMetaClient().getFs().getFileStatus(Objects.requireNonNull(writer).getLogFile().getPath()),
- 1L);
-
- return HoodieRollbackStat.newBuilder()
- .withPartitionPath(partitionPath)
- .withRollbackBlockAppendResults(filesToNumBlocksRollback)
- .withWrittenLogFileSizeMap(writtenLogFileSizeMap).build();
+ return new HoodieRollbackRequest(partitionPath, fileId, baseCommitTime, Collections.emptyList(), writtenLogFileStrSizeMap);
}
/**
* Returns written log file size map for the respective baseCommitTime to assist in metadata table syncing.
- * @param partitionPath partition path of interest
+ *
+ * @param partitionPath partition path of interest
* @param baseCommitTime base commit time of interest
- * @param fileId fileId of interest
+ * @param fileId fileId of interest
* @return Map<FileStatus, File size>
* @throws IOException
*/
protected Map<FileStatus, Long> getWrittenLogFileSizeMap(String partitionPath, String baseCommitTime, String fileId) throws IOException {
- return Collections.EMPTY_MAP;
+ // collect all log files that is supposed to be deleted with this rollback
+ return FSUtils.getAllLogFiles(table.getMetaClient().getFs(),
Review comment:
should this go through metadata table for listing? would not doing so cause any issues? i.e we may log the rollback some place thats not reachable from metadata table and thus fail to interpret the rollback command
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/rollback/SparkCopyOnWriteListingBasedRollbackStrategy.java
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.table.action.rollback;
+
+import org.apache.hudi.avro.model.HoodieRollbackRequest;
+import org.apache.hudi.common.engine.HoodieEngineContext;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.table.HoodieTable;
+
+import java.util.List;
+
+public class SparkCopyOnWriteListingBasedRollbackStrategy extends ListingBasedRollbackStrategy {
+
+ public SparkCopyOnWriteListingBasedRollbackStrategy(HoodieEngineContext context,
+ HoodieWriteConfig config,
+ HoodieTable table,
+ String instantTime) {
+ super(table, context, config, instantTime);
+ }
+
+ @Override
+ public List<HoodieRollbackRequest> getRollbackRequest(HoodieInstant instantToRollback) {
+ List<ListingBasedRollbackRequest> rollbackRequests = RollbackUtils.generateRollbackRequestsByListingCOW(context,
+ table.getMetaClient().getBasePath(), config);
+ List<HoodieRollbackRequest> listingBasedRollbackRequests = new SparkListingBasedRollbackHelper(table.getMetaClient(), config)
+ .getRollbackRequestsForRollbackPlan(context, instantToRollback, rollbackRequests);
+ return listingBasedRollbackRequests;
+ }
+}
Review comment:
just have one class for COW and MOR ? and branch internally using table type?
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackHelper.java
##########
@@ -1,252 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.hudi.table.action.rollback;
-
-import org.apache.hudi.client.common.HoodieSparkEngineContext;
-import org.apache.hudi.common.HoodieRollbackStat;
-import org.apache.hudi.common.engine.HoodieEngineContext;
-import org.apache.hudi.common.fs.FSUtils;
-import org.apache.hudi.common.model.HoodieFileFormat;
-import org.apache.hudi.common.model.HoodieLogFile;
-import org.apache.hudi.common.table.HoodieTableMetaClient;
-import org.apache.hudi.common.table.log.HoodieLogFormat;
-import org.apache.hudi.common.table.log.HoodieLogFormat.Writer;
-import org.apache.hudi.common.table.log.block.HoodieCommandBlock;
-import org.apache.hudi.common.table.log.block.HoodieCommandBlock.HoodieCommandBlockTypeEnum;
-import org.apache.hudi.common.table.log.block.HoodieLogBlock.HeaderMetadataType;
-import org.apache.hudi.common.table.timeline.HoodieInstant;
-import org.apache.hudi.config.HoodieWriteConfig;
-import org.apache.hudi.exception.HoodieIOException;
-import org.apache.hudi.exception.HoodieRollbackException;
-
-import org.apache.hadoop.fs.FileStatus;
-import org.apache.hadoop.fs.FileSystem;
-import org.apache.hadoop.fs.PathFilter;
-import org.apache.log4j.LogManager;
-import org.apache.log4j.Logger;
-import org.apache.spark.api.java.JavaPairRDD;
-import org.apache.spark.api.java.JavaSparkContext;
-
-import java.io.IOException;
-import java.io.Serializable;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Objects;
-import java.util.stream.Collectors;
-
-import scala.Tuple2;
-
-/**
- * Performs Rollback of Hoodie Tables.
- */
-public class ListingBasedRollbackHelper implements Serializable {
Review comment:
can bunch of this live in client-common?
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java
##########
@@ -92,30 +88,74 @@ public BaseRollbackActionExecutor(HoodieEngineContext context,
}
}
- protected abstract RollbackStrategy getRollbackStrategy();
+ /**
+ * Execute actual rollback and fetch list of RollbackStats.
+ * @param hoodieRollbackPlan instance of {@link HoodieRollbackPlan} that needs to be executed.
+ * @return a list of {@link HoodieRollbackStat}s.
+ * @throws IOException
+ */
+ protected abstract List<HoodieRollbackStat> executeRollback(HoodieRollbackPlan hoodieRollbackPlan) throws IOException;
+
+ private HoodieRollbackMetadata runRollback(HoodieTable<T, I, K, O> table, HoodieInstant rollbackInstant, HoodieRollbackPlan rollbackPlan) {
+ ValidationUtils.checkArgument(rollbackInstant.getState().equals(HoodieInstant.State.REQUESTED)
+ || rollbackInstant.getState().equals(HoodieInstant.State.INFLIGHT));
+ try {
+ final HoodieInstant inflightInstant;
+ final HoodieTimer timer = new HoodieTimer();
+ timer.startTimer();
+ if (rollbackInstant.isRequested()) {
+ inflightInstant = table.getActiveTimeline().transitionRollbackRequestedToInflight(rollbackInstant,
+ TimelineMetadataUtils.serializeRollbackPlan(rollbackPlan));
+ } else {
+ inflightInstant = rollbackInstant;
+ }
+
+ HoodieTimer rollbackTimer = new HoodieTimer().startTimer();
+ List<HoodieRollbackStat> stats = doRollbackAndGetStats(rollbackPlan);
+ HoodieRollbackMetadata rollbackMetadata = TimelineMetadataUtils.convertRollbackMetadata(
+ instantTime,
+ Option.of(rollbackTimer.endTimer()),
+ Collections.singletonList(instantToRollback),
+ stats);
+ if (!skipTimelinePublish) {
+ finishRollback(inflightInstant, rollbackMetadata);
+ }
- protected abstract List<HoodieRollbackStat> executeRollback() throws IOException;
+ // Finally, remove the markers post rollback.
+ WriteMarkersFactory.get(config.getMarkersType(), table, instantToRollback.getTimestamp())
+ .quietDeleteMarkerDir(context, config.getMarkersDeleteParallelism());
- protected abstract List<HoodieRollbackStat> executeRollbackUsingFileListing(HoodieInstant instantToRollback);
+ return rollbackMetadata;
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to rollback commit ", e);
+ }
+ }
@Override
public HoodieRollbackMetadata execute() {
- HoodieTimer rollbackTimer = new HoodieTimer().startTimer();
- List<HoodieRollbackStat> stats = doRollbackAndGetStats();
- HoodieRollbackMetadata rollbackMetadata = TimelineMetadataUtils.convertRollbackMetadata(
- instantTime,
- Option.of(rollbackTimer.endTimer()),
- Collections.singletonList(instantToRollback),
- stats);
- if (!skipTimelinePublish) {
- finishRollback(rollbackMetadata);
+ table.getMetaClient().reloadActiveTimeline();
+ List<HoodieInstant> rollBackInstants = table.getRollbackTimeline()
+ .filterInflightsAndRequested().getInstants().collect(Collectors.toList());
+ if (rollBackInstants.isEmpty()) {
+ throw new HoodieRollbackException("No Requested Rollback Instants found to execute rollback ");
+ }
+ HoodieInstant rollbackInstant = null;
+ for (HoodieInstant instant : rollBackInstants) {
+ if (instantTime.equals(instant.getTimestamp())) {
+ rollbackInstant = instant;
+ break;
+ }
+ }
+ if (rollbackInstant != null) {
+ try {
+ HoodieRollbackPlan rollbackPlan = RollbackUtils.getRollbackPlan(table.getMetaClient(), rollbackInstant);
+ return runRollback(table, rollBackInstants.get(0), rollbackPlan);
+ } catch (IOException e) {
+ throw new HoodieIOException(e.getMessage(), e);
Review comment:
add more context to the exception?
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseCopyOnWriteRollbackActionExecutor.java
##########
@@ -88,4 +89,12 @@ public BaseCopyOnWriteRollbackActionExecutor(HoodieEngineContext context,
LOG.info("Time(in ms) taken to finish rollback " + rollbackTimer.endTimer());
return stats;
}
+
+ /**
+ * Execute rollback and fetch rollback stats.
+ * @param instantToRollback instant to be rolled back.
+ * @param rollbackPlan instance of {@link HoodieRollbackPlan} for which rollback needs to be executed.
+ * @return list of {@link HoodieRollbackStat}s.
+ */
+ abstract List<HoodieRollbackStat> rollbackAndGetStats(HoodieInstant instantToRollback, HoodieRollbackPlan rollbackPlan);
Review comment:
executeRollback?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67a62e162d8b38102fa19958e9126f77a37ed6a1 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213)
* 2687fdc7838ad6ed480ed3e6064f46b656ebb1ef UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202)
* e8899ba79e726d7f0cbe271b8bfce8aba3a32056 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan to rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9ae220bf1ba4398068a549211e5215cda7a54f73 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201)
* a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226",
"triggerID" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"triggerType" : "PUSH"
}, {
"hash" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2238",
"triggerID" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"triggerType" : "PUSH"
}, {
"hash" : "9985d101215e2d5bf539b2f3bcac1e9b13982f91",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2264",
"triggerID" : "9985d101215e2d5bf539b2f3bcac1e9b13982f91",
"triggerType" : "PUSH"
}, {
"hash" : "de4e738ce07f76e2cd0a5f2adc73e7d9093aed57",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "de4e738ce07f76e2cd0a5f2adc73e7d9093aed57",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9985d101215e2d5bf539b2f3bcac1e9b13982f91 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2264)
* de4e738ce07f76e2cd0a5f2adc73e7d9093aed57 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3651: [HUDI-2422] Adding rollback plan and rollback requested instant
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3651:
URL: https://github.com/apache/hudi/pull/3651#issuecomment-917815065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2176",
"triggerID" : "aefd1e0e9062f7316ad7c5640d640f86b8493801",
"triggerType" : "PUSH"
}, {
"hash" : "f74bf781482675e666f05d13cba93539c44fab2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2179",
"triggerID" : "f74bf781482675e666f05d13cba93539c44fab2d",
"triggerType" : "PUSH"
}, {
"hash" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2194",
"triggerID" : "270525319f6fe09483704a5a5f8acd90ef78e0b7",
"triggerType" : "PUSH"
}, {
"hash" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2201",
"triggerID" : "9ae220bf1ba4398068a549211e5215cda7a54f73",
"triggerType" : "PUSH"
}, {
"hash" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2202",
"triggerID" : "a6bbab3f3ff4d4bfe834bb0a3305250b5be19afb",
"triggerType" : "PUSH"
}, {
"hash" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2210",
"triggerID" : "e8899ba79e726d7f0cbe271b8bfce8aba3a32056",
"triggerType" : "PUSH"
}, {
"hash" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2211",
"triggerID" : "1668a22c0a2fb3feb517a62e952b0d9fda0853a5",
"triggerType" : "PUSH"
}, {
"hash" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2213",
"triggerID" : "67a62e162d8b38102fa19958e9126f77a37ed6a1",
"triggerType" : "PUSH"
}, {
"hash" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2214",
"triggerID" : "2687fdc7838ad6ed480ed3e6064f46b656ebb1ef",
"triggerType" : "PUSH"
}, {
"hash" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2215",
"triggerID" : "87a2824f5800148c5ffea303d41b6ea0f4ff78ae",
"triggerType" : "PUSH"
}, {
"hash" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2216",
"triggerID" : "076a9969f6a7401052e998aa816ab9de9072d9b4",
"triggerType" : "PUSH"
}, {
"hash" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2217",
"triggerID" : "1c37c9086e407113420841df9e0a49d5813a6d0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2226",
"triggerID" : "7f511d82c75186c4e84af9aa952beea4b6186e48",
"triggerType" : "PUSH"
}, {
"hash" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2238",
"triggerID" : "7252e8168b38036ab012f08cdcfac89976bf219e",
"triggerType" : "PUSH"
}, {
"hash" : "9985d101215e2d5bf539b2f3bcac1e9b13982f91",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2264",
"triggerID" : "9985d101215e2d5bf539b2f3bcac1e9b13982f91",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7252e8168b38036ab012f08cdcfac89976bf219e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2238)
* 9985d101215e2d5bf539b2f3bcac1e9b13982f91 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2264)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org