You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ol...@apache.org on 2012/10/10 10:07:55 UTC

svn commit: r1396505 - /maven/sandbox/trunk/plugins/maven-patch-tracker-plugin/src/main/java/org/apache/maven/plugins/patchtracker/tracking/jenkins/JenkinsPatchTracker.java

Author: olamy
Date: Wed Oct 10 08:07:55 2012
New Revision: 1396505

URL: http://svn.apache.org/viewvc?rev=1396505&view=rev
Log:
handle http response

Modified:
    maven/sandbox/trunk/plugins/maven-patch-tracker-plugin/src/main/java/org/apache/maven/plugins/patchtracker/tracking/jenkins/JenkinsPatchTracker.java

Modified: maven/sandbox/trunk/plugins/maven-patch-tracker-plugin/src/main/java/org/apache/maven/plugins/patchtracker/tracking/jenkins/JenkinsPatchTracker.java
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/plugins/maven-patch-tracker-plugin/src/main/java/org/apache/maven/plugins/patchtracker/tracking/jenkins/JenkinsPatchTracker.java?rev=1396505&r1=1396504&r2=1396505&view=diff
==============================================================================
--- maven/sandbox/trunk/plugins/maven-patch-tracker-plugin/src/main/java/org/apache/maven/plugins/patchtracker/tracking/jenkins/JenkinsPatchTracker.java (original)
+++ maven/sandbox/trunk/plugins/maven-patch-tracker-plugin/src/main/java/org/apache/maven/plugins/patchtracker/tracking/jenkins/JenkinsPatchTracker.java Wed Oct 10 08:07:55 2012
@@ -64,10 +64,18 @@ public class JenkinsPatchTracker
 
             HttpResponse r = defaultHttpClient.execute( post );
 
-            log.info( "r:" + r.getStatusLine().getStatusCode() + ", status: " + r.getStatusLine().getReasonPhrase()+"," + EntityUtils.toString(  r.getEntity()) );
-
-            // FIXME verify response code !
-
+            log.debug(
+                "r:" + r.getStatusLine().getStatusCode() + ", status: " + r.getStatusLine().getReasonPhrase() + ","
+                    + EntityUtils.toString( r.getEntity() ) );
+
+            int statusCode = r.getStatusLine().getStatusCode();
+
+            // Jenkins returns 302
+            if ( statusCode != 200 || statusCode != 302 )
+            {
+                throw new PatchTrackerException(
+                    "Jenkins returned :" + statusCode + " with ReasonPhrase :" + r.getStatusLine().getReasonPhrase() );
+            }
 
             return new PatchTrackerResult();
         }