You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/30 11:41:07 UTC
[GitHub] [camel] jsolovjo opened a new pull request, #8799: [camel-resilience4j] Increase test coverage making a context pooled
jsolovjo opened a new pull request, #8799:
URL: https://github.com/apache/camel/pull/8799
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
I have made a context pooled for Resilience4jThreadPoolTest and therefore the code coverage is increased.
Specifically, doBuild() method in ResilienceProcessor class got increased coverage for if (pooled) statement.
You can compare the original coverage and its analysis with the improved one on the screenshots.
Original:
<img width="1718" alt="Original_code_coverage" src="https://user-images.githubusercontent.com/49488040/204785770-86d7eabd-e16e-4863-9e8a-cf3a719a5e95.png">
Improved:
<img width="1716" alt="Improved_code_coverage" src="https://user-images.githubusercontent.com/49488040/204785838-c8470543-e330-468c-a28d-b2f246512792.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jsolovjo commented on pull request #8799: [camel-resilience4j] Increase test coverage making a context pooled
Posted by GitBox <gi...@apache.org>.
jsolovjo commented on PR #8799:
URL: https://github.com/apache/camel/pull/8799#issuecomment-1332044244
> Can you make such test in an new unit test class so we can keep existing test as-is
Yes, sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8799: [camel-resilience4j] Increase test coverage making a context pooled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8799:
URL: https://github.com/apache/camel/pull/8799#issuecomment-1332020985
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #8799: [camel-resilience4j] Increase test coverage making a context pooled
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #8799:
URL: https://github.com/apache/camel/pull/8799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8799: [camel-resilience4j] Increase test coverage making a context pooled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8799:
URL: https://github.com/apache/camel/pull/8799#issuecomment-1332333552
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 3 | 3 | 1 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8799: [camel-resilience4j] Increase test coverage making a context pooled
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8799:
URL: https://github.com/apache/camel/pull/8799#issuecomment-1332042880
Can you make such test in an new unit test class so we can keep existing test as-is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jsolovjo commented on pull request #8799: [camel-resilience4j] Increase test coverage making a context pooled
Posted by GitBox <gi...@apache.org>.
jsolovjo commented on PR #8799:
URL: https://github.com/apache/camel/pull/8799#issuecomment-1332300044
@davsclaus does it need your approval to let the checks start running again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jsolovjo commented on pull request #8799: [camel-resilience4j] Increase test coverage making a context pooled
Posted by GitBox <gi...@apache.org>.
jsolovjo commented on PR #8799:
URL: https://github.com/apache/camel/pull/8799#issuecomment-1332210456
@davsclaus I have created a new test class, can you check it, please? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8799: [camel-resilience4j] Increase test coverage making a context pooled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8799:
URL: https://github.com/apache/camel/pull/8799#issuecomment-1332548006
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 4 | 4 | 1 | 3 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org