You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/02 08:21:53 UTC

[GitHub] [spark] amuraru commented on a change in pull request #24502: [SPARK-27610][YARN] Shade netty native libraries

amuraru commented on a change in pull request #24502: [SPARK-27610][YARN] Shade netty native libraries
URL: https://github.com/apache/spark/pull/24502#discussion_r280324547
 
 

 ##########
 File path: common/network-yarn/pom.xml
 ##########
 @@ -35,7 +35,7 @@
     <!-- Make sure all Hadoop dependencies are provided to avoid repackaging. -->
     <hadoop.deps.scope>provided</hadoop.deps.scope>
     <shuffle.jar>${project.build.directory}/scala-${scala.binary.version}/spark-${project.version}-yarn-shuffle.jar</shuffle.jar>
-    <shade>org/spark_project/</shade>
+    <shade>org/spark/project/</shade>
 
 Review comment:
   Makes sense @srowen @vanzin - updated the patch to shade in `org.sparkproject`, ie no underscore

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org