You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Adam Tamas (Code Review)" <ge...@cloudera.org> on 2020/03/02 16:22:14 UTC
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Adam Tamas has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15332
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Modified the sql_parser.cup to accept the reversed syntax.
Testing:
-swapped an instance of RANGE() + HASH() pair in test_kudu.py ->
‘test_primary_key_and_distribution()’ and left the rest to check if
it is still create the right table with ‘assert_show_create_equals()’.
Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
---
M fe/src/main/cup/sql-parser.cup
M tests/query_test/test_kudu.py
2 files changed, 10 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/15332/1
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Adam Tamas (Code Review)" <ge...@cloudera.org>.
Adam Tamas has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Modified the sql_parser.cup to accept the reversed syntax.
Testing:
-Added extra analyzer tests to cover the case when RANGE() is before HASH()
for Kudu tables.
Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
---
M fe/src/main/cup/sql-parser.cup
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
3 files changed, 19 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/15332/7
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 7
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5450/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 6
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Mar 2020 09:30:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
I just have one nit. Let me give a +1 now and once you covered that I can +2
http://gerrit.cloudera.org:8080/#/c/15332/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15332/3//COMMIT_MSG@12
PS3, Line 12: Added an extra AnalyzesOk into ‘AnalyzeKuduDDLTest()’ ->
: ‘testDDlsOnKuduTable()’ in AnalyzeKuduDDLTest.java where the RANGE() and
: HASH() pair is swapped.
nit: no need to mention the each line of test change in the commit message. A single sentence without this level of technical details is fine. Like "Added and extra analyzer test to cover the case when RANGE() is before HASH() for Kudu tables."
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 09:47:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Adam Tamas (Code Review)" <ge...@cloudera.org>.
Adam Tamas has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Modified the sql_parser.cup to accept the reversed syntax.
Testing:
-Added extra analyzer tests to cover the case when RANGE() is before HASH()
for Kudu tables.
Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
---
M fe/src/main/cup/sql-parser.cup
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
3 files changed, 19 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/15332/5
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 5
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5405/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 4
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 14:01:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Modified the sql_parser.cup to accept the reversed syntax.
Testing:
-Added extra analyzer tests to cover the case when RANGE() is before HASH()
for Kudu tables.
Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Reviewed-on: http://gerrit.cloudera.org:8080/15332
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/cup/sql-parser.cup
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
3 files changed, 19 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 9
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5417/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 7
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Mar 2020 14:10:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 4:
(2 comments)
Minor nits again. I'll +2 if these are covered
http://gerrit.cloudera.org:8080/#/c/15332/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java:
http://gerrit.cloudera.org:8080/#/c/15332/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@123
PS4, Line 123: swapped
nit: Swapped
http://gerrit.cloudera.org:8080/#/c/15332/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@128
PS4, Line 128: swapped
nit: this word is not needed (and doesn't really makes sense here)
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 4
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Mar 2020 07:47:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 6
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Mar 2020 09:30:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 8
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Mar 2020 13:52:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 3: Code-Review+1
LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 09:27:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5386/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Mar 2020 17:08:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Adam Tamas (Code Review)" <ge...@cloudera.org>.
Adam Tamas has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Modified the sql_parser.cup to accept the reversed syntax.
Testing:
-Added extra analyzer tests to cover the case when RANGE() is before HASH()
for Kudu tables.
Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
---
M fe/src/main/cup/sql-parser.cup
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
2 files changed, 17 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/15332/4
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 4
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 8
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Mar 2020 18:46:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5451/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 8
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Mar 2020 13:52:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 5
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Mar 2020 09:30:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 5:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/5415/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 5
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Mar 2020 09:56:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5385/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Mar 2020 17:07:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5402/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 10:11:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Adam Tamas (Code Review)" <ge...@cloudera.org>.
Adam Tamas has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Modified the sql_parser.cup to accept the reversed syntax.
Testing:
-Added an extra AnalyzesOk into ‘AnalyzeKuduDDLTest()’ ->
‘testDDlsOnKuduTable()’ in AnalyzeKuduDDLTest.java where the RANGE() and
HASH() pair is swapped.
Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
---
M fe/src/main/cup/sql-parser.cup
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/15332/2
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 2:
(1 comment)
Thank you for updating.
One small nit, other than that LGTM.
http://gerrit.cloudera.org:8080/#/c/15332/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java:
http://gerrit.cloudera.org:8080/#/c/15332/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@127
PS2, Line 127:
nit: extra space
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 09:02:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5450/
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 6
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Mar 2020 10:55:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Adam Tamas (Code Review)" <ge...@cloudera.org>.
Adam Tamas has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Modified the sql_parser.cup to accept the reversed syntax.
Testing:
-Added an extra AnalyzesOk into ‘AnalyzeKuduDDLTest()’ ->
‘testDDlsOnKuduTable()’ in AnalyzeKuduDDLTest.java where the RANGE() and
HASH() pair is swapped.
Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
---
M fe/src/main/cup/sql-parser.cup
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/15332/3
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15332/3/fe/src/main/cup/sql-parser.cup
File fe/src/main/cup/sql-parser.cup:
http://gerrit.cloudera.org:8080/#/c/15332/3/fe/src/main/cup/sql-parser.cup@1601
PS3, Line 1601: followed by
The comment should be also updated.
http://gerrit.cloudera.org:8080/#/c/15332/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java:
http://gerrit.cloudera.org:8080/#/c/15332/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@124
PS3, Line 124: A
Can you add another test with range partitions first + multiple levels of hash partitions? The test at line 132 is an example for that syntax.
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 11:50:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 7
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Mar 2020 13:51:15 +0000
Gerrit-HasComments: No